Fixed CppCheck: (performance) Possible inefficient checking for empti…

…ness.
cuberite · Jan 17, 2015 · 3dc994f · 3dc994f
1 parent 2ce2741
commit 3dc994f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/LightingThread.cpp b/src/LightingThread.cpp
@@ -197,7 +197,7 @@ void cLightingThread::Execute(void)
 	{
 		{
 			cCSLock Lock(m_CS);
-			if (m_Queue.size() == 0)
+			if (m_Queue.empty())
 			{
 				cCSUnlock Unlock(Lock);
 				m_evtItemAdded.Wait();

diff --git a/src/MobProximityCounter.cpp b/src/MobProximityCounter.cpp
@@ -50,7 +50,7 @@ cMobProximityCounter::sIterablePair cMobProximityCounter::getMobWithinThosesDist
 	a_DistanceMin *= a_DistanceMin;// this is because is use square distance
 	a_DistanceMax *= a_DistanceMax;
 
-	if (m_DistanceToMonster.size() <= 0)
+	if (m_DistanceToMonster.empty())
 	{
 		convertMaps();
 	}

diff --git a/src/OSSupport/Queue.h b/src/OSSupport/Queue.h
@@ -86,7 +86,7 @@ class cQueue
 	bool TryDequeueItem(ItemType & item)
 	{
 		cCSLock Lock(m_CS);
-		if (m_Contents.size() == 0)
+		if (m_Contents.empty())
 		{
 			return false;
 		}
@@ -101,7 +101,7 @@ class cQueue
 	ItemType DequeueItem(void)
 	{
 		cCSLock Lock(m_CS);
-		while (m_Contents.size() == 0)
+		while (m_Contents.empty())
 		{
 			cCSUnlock Unlock(Lock);
 			m_evtAdded.Wait();

diff --git a/src/Server.cpp b/src/Server.cpp
@@ -764,7 +764,7 @@ void cServer::cNotifyWriteThread::Execute(void)
 	while (!m_ShouldTerminate)
 	{
 		cCSLock Lock(m_CS);
-		while (m_Clients.size() == 0)
+		while (m_Clients.empty())
 		{
 			cCSUnlock Unlock(Lock);
 			m_Event.Wait();