Windows Environment Vars are converted to all upper case #300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #291
WindowsEnvironmentVars < Environment
converts all ENV keys to upper case on initialization.WindowsPlatform
now usesWindowsEnvironmentVars
as its environment:Rspec tests for
WindowsEnvironmentVars
included to be sure that accessing the environment variables by the keys will work and thatWindowsEnvironmentVars.keys
only has upper case chars.WindowsEnvironmentVars.keys
only has upper case chars." really means that it only checks to be sure that none of the keys match/[a-z]+/
I think that might not catch lower case unicode chars that don't get 'upper-cased' by[String].upcase