Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gherkin Lint - New project? #59

Closed
aslakhellesoy opened this issue Aug 8, 2016 · 24 comments
Closed

Gherkin Lint - New project? #59

aslakhellesoy opened this issue Aug 8, 2016 · 24 comments
Labels
⌛ stale Will soon be closed by stalebot unless there is activity language: javascript

Comments

@aslakhellesoy
Copy link
Contributor

A recent discussion in the cucumber/gherkin gitter room revealed that there are (at least) 3 Cucumber linters out there:

The projects are similar, and I think there are some great unique things in each one of them.

What do you think about joining forces to create a single one to rule them all? Ideally in JavaScript since it's easier to use on the web, and also relatively easy to embed into other libraries as well as editors and IDEs.

If you're interested, just reply here and fill out this doodle for a google hangout kickoff meeting.

/cc @enkessler @allustin @vsiakka @r-cochran

@ghost
Copy link

ghost commented Aug 8, 2016

i am interested.

found another projects

may be dead

https://github.com/wimpheling/codemirror-gherkin-linter
https://github.com/mekentosj/ling

on ruby with some usefull checks

https://github.com/funkwerk/gherkin_lint#checks

@vsiakka
Copy link

vsiakka commented Aug 8, 2016

I am interested!

@Pr-Mex
Copy link
Contributor

Pr-Mex commented Aug 8, 2016

+1

@r-cochran
Copy link

I am interested

@aslakhellesoy
Copy link
Contributor Author

Thanks for doodling everyone. I've picked a time the upcoming Friday.

Proposed agenda

  • Introduce ourselves quickly
  • Agree on high level goals for the project
  • Decide what to do next and who does what

We'll take lo-fi minutes in gitter and paste a summary in this ticket later.

Homework before hangout

Study the various implementations listed above and write down a list of things you'd
like to see in the official implementation. This will help us come up with better goals.

Thanks for participating everyone - I'm really excited about this!

@AlexeyBuzdin
Copy link

Will be glad to join!

@enkessler
Copy link

Good to go!

@aslakhellesoy
Copy link
Contributor Author

There is also @charlierudolph's https://github.com/charlierudolph/cucumber_lint that we can use as inspiration

@aslakhellesoy
Copy link
Contributor Author

aslakhellesoy commented Sep 14, 2016

Some of us ran a Google Hangout meeting on 12th Aug 2016. The minutes are here.

@aslakhellesoy
Copy link
Contributor Author

I just fixed the sharing access of that google doc. Anyone with the link can see it and comment on it.

@gmk1217
Copy link
Contributor

gmk1217 commented Sep 14, 2016

Hi Cukes,
https://github.com/cucumber/gherkin-lint

Is this link working?
got 404 error.


Mohan Krishna Gundala
[image: https://]about.me/gmk.india
https://about.me/gmk.india?promo=email_sig&utm_source=email_sig&utm_medium=email_sig&utm_campaign=external_links

On Wed, Sep 14, 2016 at 6:13 PM, Aslak Hellesøy notifications@github.com
wrote:

I just fixed the sharing access of that google doc. Anyone with the link
can see it and comment on it.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#59 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFIicRbbKISIh8tMt7oAJtUrTruOB9zIks5qp-vfgaJpZM4Jes1Y
.

@aslakhellesoy
Copy link
Contributor Author

@gmk1217 where did you find a broken link to https://github.com/cucumber/gherkin-lint ?

(The correct link is https://github.com/cucumber/gherkin-lint-javascript)

@gmk1217
Copy link
Contributor

gmk1217 commented Sep 14, 2016

it's the google doc which you have shared

https://docs.google.com/document/d/16phGnd-hd2GcN118Irn1ccpm-4JqBB9wfBVB9cXDIIo/edit#


Mohan Krishna Gundala
[image: https://]about.me/gmk.india
https://about.me/gmk.india?promo=email_sig&utm_source=email_sig&utm_medium=email_sig&utm_campaign=external_links

On Wed, Sep 14, 2016 at 7:03 PM, Aslak Hellesøy notifications@github.com
wrote:

@gmk1217 https://github.com/gmk1217 where did you find a broken link to
https://github.com/cucumber/gherkin-lint ?

(The correct link is https://github.com/cucumber/gherkin-lint-javascript)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#59 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFIicdwGcpkBBglJkyNU4mWLDXt1Njveks5qp_eZgaJpZM4Jes1Y
.

@aslakhellesoy
Copy link
Contributor Author

Here is another one: https://github.com/wesovilabs/gherkinize by @ivancorrales

I'll let everyone in this issue know when gherkin-lint is open for contribution - been busy doing other things (such as adding event protocol support to gherkin, which will simplify gherkin-lint architecture considerably)

@igas
Copy link

igas commented Oct 5, 2017

@aslakhellesoy it's great that you are working on consolidation of linters. Thanks for all your work. Do you have any project updates?

@aslakhellesoy
Copy link
Contributor Author

I haven't made any progress I'm afraid. Too many other responsibilities.

@stale
Copy link

stale bot commented Dec 5, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Dec 5, 2017
@enkessler
Copy link

One more gherkin linter. This is one is also in Ruby but is actively maintained.

@stale stale bot removed the ⌛ stale Will soon be closed by stalebot unless there is activity label Dec 7, 2017
@DwordPtr
Copy link

As I created the issue above. I am interested. How much work/process would it take to bring the gherkin-lint npm package into the monorepo?

Doubtless there will be stuff we don't like but having a starting spot that already works.

Goes without saying I don't mind helping out where I can (and am qualified to)

@enkessler
Copy link

Setting aside the risk of my participation giving the project the touch of death, I remain more than happy to help in a limited capacity (I've never made an NPM package before).

@DwordPtr
Copy link

I made a super simple one to try it out. The tooling is pretty nice. The hardest part is knowing what the ast will look like in a dynamically typed language.

@stale
Copy link

stale bot commented Feb 28, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Feb 28, 2018
@stale
Copy link

stale bot commented Mar 7, 2018

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

@stale stale bot closed this as completed Mar 7, 2018
@lock
Copy link

lock bot commented Mar 7, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⌛ stale Will soon be closed by stalebot unless there is activity language: javascript
Projects
None yet
Development

No branches or pull requests

9 participants