Clojure native #138
Clojure native #138
Conversation
Conflicts: clojure/src/main/java/cucumber/runtime/clojure/ClojureBackend.java clojure/src/main/java/cucumber/runtime/clojure/ClojureHook.java clojure/src/main/java/cucumber/runtime/clojure/ClojureHookDefinition.java clojure/src/main/java/cucumber/runtime/clojure/ClojureStepDefinition.java
| @@ -78,7 +78,9 @@ public void runStep(Locale locale) throws Throwable { | |||
|
|
|||
There was a problem hiding this comment.
This class is no longer used - am I correct? Delete it?
There was a problem hiding this comment.
Never mind my last comment.
|
RE: snippets: I'll refactor it to make it easier to use. (Replace inheritance with delegation) RE: tests: You haven't tried to run the tests? How do you know if this works then? RE: Changes to FileResourceLoader. What changes are you referring to? Feel free to change back to the ClasspathResourceLoader if that makes more sense. |
|
I am interested in using cucumber for integration tests for a clojure application. in the process of writing this I also wrote my first feature and scenarios for doing the integration testing. That's how I know the code "works". I would like to get the existing tests working, there are some files in clojure/src/test but when I run 'mvn test' nothing happens, this may be the result of me adding clojure-maven-plugin to the pom. I'm not a big maven guy, we use leiningen at work. As I was working on this at someone point when I merged in master things broke and I had to fiddle with the paths passed in to cli.Main (this was before I stopped using cli.Main in the lein plugin) and I thought that somehow the Backend switched from getting passed a ClasspathResourceLoader to a FileResourceLoader, perhaps this is incorrect. |
|
Did you have a chance to look at the Snippet API after I refactored it? Now you just have an interface to implement - much better separation IMO. I haven't tried your code yet (it no longer applies cleanly with master). Can you try to run the regular ant build and make sure it works? Currently a Backend is instantiated with a ClasspathResourceLoader when kicked off from JUnit, and a FileResourceLoader when kicked off from the CLI. This seems like a sensible default, especially since Java people will prefer the JUnit runner, while e.g. jruby/jython/rhino etc people will prefer the CLI. Clojure seems like an exception to the rule (jruby/jython/rhino don't use the CLASSPATH), so maybe you should ignore the resourceLoader passed to the ctor and always use a ClasspathResourceLoader. |
|
I ran "mvn clean install" on the clojure-native branch and it fails when running the test cucumber.resources.ResourcesTest. That file doesn't seems to contain any actual tests however. This doesn't occur on the master branch of cucumber-jvm, main repo (but as a side note, a Groovy test fails). |
|
Is anyone interested in bringing this uptodate with the current master HEAD? If not I'll close this issue. /cc @hiredman @rplevy-draker @nilswloka |
|
I'm not sure whether I have sufficient Clojure skills, but I can give it a try. I'm still very much interested in a native version. |
|
Sent a pull request: #265 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
rewrite of the clojure backend in clojure