Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tags and merge tag-expressions #63

Merged
merged 3 commits into from
Nov 9, 2017
Merged

Update tags and merge tag-expressions #63

merged 3 commits into from
Nov 9, 2017

Conversation

mlvandijk
Copy link
Member

Update tags as mentioned in #25
Use some details from cucumber/common#34

@@ -26,27 +24,31 @@ A Scenario or Feature can have as many Tags as you like. Just separate them with
Feature: Verify billing
Copy link
Member

@tsundberg tsundberg Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This renders funny. Is it a mistake or a feature?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you be more specific?

Copy link
Member

@tsundberg tsundberg Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlvandijk took a screenshot and shared it in slack. I share here image here,
screenshot from 2017-11-09 12-37-02

It is fixed now.

Copy link
Member Author

@mlvandijk mlvandijk Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a problem with text marked with 'shell':
screen shot 2017-11-09 at 12 48 11
If possible please merge text changes before fixing on master, to prevent merge conflicts

@mlvandijk mlvandijk merged commit f03ce92 into master Nov 9, 2017
@mlvandijk mlvandijk deleted the tags branch November 9, 2017 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants