Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont link out at the top of the file like that #83

Merged
merged 2 commits into from
Dec 8, 2017
Merged

Dont link out at the top of the file like that #83

merged 2 commits into from
Dec 8, 2017

Conversation

plaindocs
Copy link
Contributor

  • people will think it is a TOC

@@ -1,17 +1,11 @@
---
menu: reference
renderer: Cucumber::Website::Reference
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 'renderer:' as I don't think it's used anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so if we're listing tools like this - best to show people what there is. We should however make it more clear which are language specific

@@ -89,6 +83,8 @@ Then("^the page title should start with "([^"]*)"$") do
end
```

More information on [Selenium Webdriver](http://docs.seleniumhq.org/projects/webdriver/).

# Watir Webdriver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watir is Ruby specific so show only for Ruby page?

@@ -229,6 +227,14 @@ public class GoogleHomePage extends PageObject {
public class SearchResultsPage extends PageObject {}
```

More information on [Serenity](http://serenity-bdd.info).

# Capybara
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capybara is Ruby specific so show only for Ruby page

@mlvandijk mlvandijk mentioned this pull request Dec 8, 2017
10 tasks
@mlvandijk mlvandijk merged commit ad98be9 into master Dec 8, 2017
@olleolleolle olleolleolle deleted the sw-ba branch December 8, 2017 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants