Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart: Acceptance tests are not implemented #30

Open
Tracked by #2
mpkorstanje opened this issue Nov 8, 2022 · 1 comment
Open
Tracked by #2

dart: Acceptance tests are not implemented #30

mpkorstanje opened this issue Nov 8, 2022 · 1 comment

Comments

@mpkorstanje
Copy link
Contributor

🤔 What's the problem you've observed?

The Gherkin Parser for Dart does not implement the acceptance tests (e.g. compare the make file to to the javascript implementation). This is a problem because:

As of May 2016 Gherkin is implemented in 8 languages. This number is likely to increase to a dozen within a year or two. Very few programmers are intimate with all those languages. Therefore, in order to make it as easy as possible to refactor, fix bugs, add features and release packages it is essential that all implementations have a similar structure.

CONTRIBUTING.md - consistency between implementations

✨ Do you have a proposal for making it better?

Either:

  • Use Berp to generate the parser.
  • Remove Dart.

📚 Any additional context?

The Parser for Dart is also not generated using Berp #29

@mpkorstanje mpkorstanje changed the title dart: dart: Acceptance tests are not implemented Nov 8, 2022
@mpkorstanje
Copy link
Contributor Author

Note: Dart does actually implement some acceptance tests by duplicating the test data:

https://github.com/cucumber/gherkin/tree/main/dart/test/assets/testdata

The parser implementation however does not retain the StepKeywordType and so we can not use the actual acceptance test data (see #34).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant