-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use sans-serif font most of the time #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aurelien-reeves this took me a while to figure out! Here's the feature from the CCK: Feature: Attachments
It is sometimes useful to take a screenshot while a scenario runs.
Or capture some logs.
Cucumber lets you `attach` arbitrary files during execution, and you can
specify a content type for the contents.
Formatters can then render these attachments in reports.
Attachments must have a body and a content type
Scenario: Strings can be attached with a media type
Beware that some formatters such as @cucumber/react use the media type
to determine how to display an attachment.
When the string "hello" is attached as "application/octet-stream" From debugging, it seems the leading whitespace in the descriptions is preserved when Gherkin parses, so each line of the scenario description has four leading spaces. We then treat it as Markdown, which interprets the four leading spaces as a code block: Is this something we need to fix in Gherkin i.e. replicate the same behaviour as doc strings for normalising indentation? |
Wow 🤯 I would say that we may have to fix this in gherkin. I see any reason why those spaces are kept in the description. However, @aslakhellesoy may certainly have way more context than I have 😅 |
In the meantime, we may consider that PR done and treat that "issue" apart, whatever we decide it is an issue in gherkin, or we should treat it in react |
Agree we should fix this in Gherkin. |
🤔 What's changed?
Changed the font for our React components to sans serif (copied from Tailwind's standard sans-serif stack) except:
⚡️ What's your motivation?
Fixes #84.
🏷️ What kind of change is this?
📋 Checklist: