Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use sans-serif font most of the time #97

Merged
merged 4 commits into from
Mar 22, 2022
Merged

use sans-serif font most of the time #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e985885
use sans-serif font most of the time
davidjgoss Mar 15, 2022
3b142f2
add changelog entry
davidjgoss Mar 15, 2022
1928367
Merge branch 'main' into font-sans-mono
davidjgoss Mar 16, 2022
877b60d
Merge branch 'main' into font-sans-mono
davidjgoss Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Changed
- Most content is now rendered with a sans serif font.

## [19.0.0] - 2022-01-24
### Added
Expand Down
2 changes: 1 addition & 1 deletion src/components/CucumberReact.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

.cucumberReact {
font-size: 14px;
font-family: ui-monospace, SFMono-Regular, Menlo, Monaco, Consolas, 'Liberation Mono', 'Courier New', monospace;
font-family: $sansFamily;
color: $textColor;
background: $backgroundColor;
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/gherkin/Attachment.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

.text {
white-space: pre-wrap;
font-family: inherit;
font-family: $monoFamily;
font-size: 0.875em;
padding: 0.666em 0.75em;
border-radius: 0.25em;
Expand Down
2 changes: 1 addition & 1 deletion src/components/gherkin/DocString.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@import '../../styles/theming';

.docString {
font-family: inherit;
font-family: $monoFamily;
color: $docstringColor;
padding-bottom: 0.25em;
margin: 0;
Expand Down
4 changes: 2 additions & 2 deletions src/components/gherkin/ErrorMessage.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

.message {
white-space: pre-wrap;
font-family: inherit;
font-family: $monoFamily;
font-size: 0.875em;
padding: 0.666em 0.75em;
border-radius: 0.25em;
margin: 0;
overflow-x: auto;
background-color: $errorBackgroundColor;
color: $errorTextColor;
}
}
2 changes: 2 additions & 0 deletions src/styles/theming.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
$sansFamily: 'Inter var', ui-sans-serif, system-ui, -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, 'Helvetica Neue', Arial, 'Noto Sans', sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji';
$monoFamily: ui-monospace, SFMono-Regular, Menlo, Monaco, Consolas, 'Liberation Mono', 'Courier New', monospace;
$backgroundColor: var(--cucumber-background-color, white);
$textColor: var(--cucumber-text-color, #222);
$anchorColor: var(--cucumber-anchor-color, #297bde);
Expand Down