Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GDTF Initialization #61

Open
Firionus opened this issue Dec 18, 2021 · 0 comments
Open

Refactor GDTF Initialization #61

Firionus opened this issue Dec 18, 2021 · 0 comments

Comments

@Firionus
Copy link
Contributor

The current implementation has some code smells, like functions with many arguments and deep nesting. This might be helped with dedicated "context objects" that only exist during initialization, which might also make it possible to remove the field originalChannelFunction from GlowChannelFunction that is only needed during initialization.

Also, the error handling should be unified. See this note from #58:

A warnings field in the GdtfWrapper should contain non-fatal warnings about the file. In fact, I think we currently throw for a lot of cases where we could just ignore that specific part of the file. Guideline: Parse as much as possible, while not arbitrarily choosing to perform undefined behavior.

This warnings field should also be shown in the UI.

@Firionus Firionus mentioned this issue Dec 18, 2021
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant