Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests/phantomJS #270

Open
mapsam opened this issue Jan 22, 2018 · 1 comment
Open

Fix tests/phantomJS #270

mapsam opened this issue Jan 22, 2018 · 1 comment

Comments

@mapsam
Copy link
Member

mapsam commented Jan 22, 2018

@nickpeihl pointed out PhantomJS is broken, and therefore all of our tests aren't working in #269. This means that PRs are red or "pending" and codeship doesn't deploy any changes to master. To get the jQuery security fix out, I went ahead and removed tests in 7842bcc but we should get these up and running again (or refactor the test suite).
@mapsam
Copy link
Member Author

mapsam commented Jan 22, 2018

Just a little proof that codeship is 👍 with tests commented out

screen shot 2018-01-22 at 10 29 47 am

jQuery security updates have been shipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mapsam