Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_unCollect should run on files added, rather than executed #92

Closed
mapsam opened this issue May 12, 2015 · 4 comments
Closed

_unCollect should run on files added, rather than executed #92

mapsam opened this issue May 12, 2015 · 4 comments
Labels

Comments

@mapsam
Copy link
Member

mapsam commented May 12, 2015

Right now if someone adds a featureCollection of a single feature from their desktop, it stays the same. When adding the feature to the map, we should _unCollect() instead of that function only existing withing GeoExecute.js

@mapsam mapsam added the bug label May 12, 2015
@mapsam
Copy link
Member Author

mapsam commented May 12, 2015

Similarly, what happens if turf requires a feature collection but the object is only a feature?

@mapsam
Copy link
Member Author

mapsam commented May 12, 2015

Another thought is to actually turn everything into a featureCollection, and then run operations recursively if turf only accepts a feature at a time. Thoughts @alukach?

@alukach
Copy link
Member

alukach commented May 13, 2015

Haven't thought too much about this, but at first blush something irks me about changing data automatically upon upload. I like my data to stay pure, unadulterated, unless absolutely necessary.

@mapsam
Copy link
Member Author

mapsam commented Sep 12, 2015

I think you are correct, @alukach doing this on load isn't a good idea. Might be a fun extra function to create, though - "Turn feature collection into unique features" action.

@mapsam mapsam closed this as completed Sep 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants