Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 Not Found on domReady.js, other plugins #4

Closed
asilvas opened this issue Aug 15, 2011 · 9 comments
Closed

404 Not Found on domReady.js, other plugins #4

asilvas opened this issue Aug 15, 2011 · 9 comments
Assignees
@unscriptable
Milestone
0.5.2

Comments

@asilvas
Copy link
Contributor

asilvas commented Aug 15, 2011

Using the 0.5 release, with "dist/curl-kitchen-sink" or "dist/curl-with-js-and-domReady", the following code will result in an unexpected request for domReady.js file... My understanding is that the "domReady" plugin is part of these distros, so is this a bug or am I missing something?

<!DOCTYPE html>
<html>
<head>
    <title>Index</title>
    <script src="scripts/curl.js"" type="text/javascript"></script>
</head>
<body>

<script>
    curl(["js!scripts/test.js"])
    .then(function () {
        console.log('test1 done');
    });
</script>


</body>
</html>
@asilvas
Copy link
Contributor Author

asilvas commented Aug 15, 2011

Bit more info. First of all, the file shouldn't be requested at all, unless I'm missing something. But when it is requested, it is hitting "undefined/domReady.js". The 2nd part probably isn't important, as it is likely due to plugins path not being defined (I kept my example code simple to isolate this issue), but wanted to include just in case.

@ghost ghost assigned unscriptable Aug 16, 2011
@unscriptable
Copy link
Member

This is easily reproduced in the tests. It seems that curl's simplified make.sh script (which is used to create the compiled versions in the dist/ folder) is too simplistic to handle parent module ids. The real fix would be to start using cram to compile these versions, but for now, I just changed the domReady! plugin's call to the domReady module from "../domReady" to "curl/domReady". Will commit this to dev branch and release it as 0.5.1 after running tests.

@asilvas
Copy link
Contributor Author

asilvas commented Aug 16, 2011

Good deal. Figured it was something simple. Thanks!

@unscriptable
Copy link
Member

I just pushed 0.5.1 after checking it in the tests. Feel free to test it in your env and close this ticket if it's fixed for you. -- J

@asilvas
Copy link
Contributor Author

asilvas commented Aug 16, 2011

You're on fire! I'll close in morning after I verify. Thanks!

@asilvas asilvas closed this as completed Aug 16, 2011
@asilvas asilvas reopened this Aug 16, 2011
@asilvas
Copy link
Contributor Author

asilvas commented Aug 16, 2011

Similar issue found with "css" plugin, using 0.5.1.

@unscriptable
Copy link
Member

I just verified that the css! and async! plugin have a sightly different issue that manifests itself the same way.

@unscriptable
Copy link
Member

Committed a fix to the dev branch: https://github.com/unscriptable/curl/tree/dev. Milestone: 0.5.2.

@asilvas
Copy link
Contributor Author

asilvas commented Aug 17, 2011

Verified css! is fixed. Thanks!

@asilvas asilvas closed this as completed Aug 17, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unscriptable unscriptable

Labels
None yet
Projects
None yet
Milestone
0.5.2
Development

No branches or pull requests
2 participants
@unscriptable @asilvas