Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ES6 Array.prototype.find and Array.prototype.findIndex #19

Open
unscriptable opened this issue Mar 15, 2013 · 3 comments
Open

Comments

@unscriptable
Copy link
Member

See these gists:

find: https://gist.github.com/rwldrn/5079436

findIndex: https://gist.github.com/rwldrn/5079427

@unscriptable
Copy link
Member Author

Where do we put these? In the poly/array module? But then we can't have poly/es5. Do people care?

@briancavalier
Copy link
Member

Cool. I've wanted these many times--much more useful, IMHO, than indexOf. How about an es6 dir with poly/es6/array (or maybe name it es6ish?), which could pull in poly/array (which we could consider moving to poly/es5/array, but that could be a breaking change for some users). Then we could offer a poly/es6 shim (sham)?

@ljharb
Copy link

ljharb commented Apr 21, 2013

If you want all the shimmable features in ES6, I recommend just including https://github.com/paulmillr/es6-shim/ which is up to date with the current spec, and fully tested. Patches welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants