Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests should run against the standalone functions? #2

Closed
briancavalier opened this issue Nov 17, 2011 · 0 comments
Closed

Unit tests should run against the standalone functions? #2

briancavalier opened this issue Nov 17, 2011 · 0 comments

Comments

@briancavalier
Copy link
Member

I'm thinking that the unit tests should be run against the non-prototype-augmented functions. For example, poly's array.map should be tested by calling array.map(testArray, mapFunc) rather than testArray.map(mapFunc). That way, poly's shims can be fully tested in any environment, rather than only in envs that need shimming.

Then there could be separate unit tests to actually test whether poly's shimming mechanism itself works correctly. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants