Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ULS UNITS - Review all snippets created via snippets plugin on units libraries #508

Open
manolobevia opened this issue Oct 3, 2019 · 4 comments
Assignees
Milestone

Comments

@manolobevia
Copy link
Contributor

  • Move to CULU css snippets that belong to the theme and not to individual units. There are too much css duplication.

  • Move to CULU php snippets that belong to the theme.

@kevinkidwell
Copy link
Contributor

@manolobevia I recently went through with the custom loop widget and looked through all of these snippets, all info in #735. All of the snippets that can be in the loop widget are there, all that can't be moved out have been noted, and snippets have been cleaned up across the board.

In doing all of that, I consolidated the CSS from all of the unit snippets that was being used and compiled it into a single file. I don't know if any of it clashes with theme code but I wanted to add it here so that you can take a look and see if any does and could be updated. Almost all of the units are currently using some of these styles so if we can get them added into the theme, then we can remove the snippets.

Consolidated CSS:
consolidated.css.zip

@JesiBuell79
Copy link

Need to check if this work was done or not

@sarah-cul
Copy link
Contributor

sarah-cul commented Sep 15, 2023

@JesiBuell79
This was not done yet, but the idea is a good one so I think we can keep this in the backlog.

Issue: There are large chunks of css in several of the unit library sites located in snippets... that appear to be identical. This could be a maintenance headache in that if the style needs to be updated, it would have to be updated on all the unit sites.

Solution: move those repetitive chunks of css into the theme https://github.com/cul-it/wp-cul-theme-culu so it will only have to be maintained in one place

@sarah-cul
Copy link
Contributor

Also, realized some of the custom post loop code was still in code snippets for Mann, Olin Uris, and Catherwood. This was all deactivated and fixed the custom post loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants