Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grapher + React List Container #51

Closed
SachaG opened this issue Oct 25, 2016 · 2 comments
Closed

Grapher + React List Container #51

SachaG opened this issue Oct 25, 2016 · 2 comments

Comments

@SachaG
Copy link

SachaG commented Oct 25, 2016

Grapher looks really nice! It reminds me of a better version of react-list-container, which we're currently using for Telescope.

We're thinking about migrating to Apollo/GraphQL though, in which case I would probably no longer maintain react-list-container. If that happens, would it be ok to point people to Grapher or somehow merge both projects? What do you think?

@theodorDiaconu
Copy link
Contributor

theodorDiaconu commented Oct 25, 2016

I see what you mean, but that concern is for "grapher-react".
https://github.com/cult-of-coders/grapher-react/issues

We can build it upon. But instead of offering an integration for your package. I believe it would be better to take some parts of your code, keep ofcourse yourself as @author, and put it there.

<ListContainer collection={Posts} publication="posts.list" component={PostList}/>

...morphs into...

<ListContainer query={query} queryParameters?={} component={PostList} pagination={Component} />

Yep, I agree to point them to grapher-react, however only after this is properly implemented and tested.

@SachaG
Copy link
Author

SachaG commented Oct 26, 2016

Oh perfect, I hadn't seen grapher-react :)

@SachaG SachaG closed this as completed Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants