Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static records should only be served for the root domain #8

Closed
normanr opened this issue Mar 16, 2020 · 4 comments
Closed

Static records should only be served for the root domain #8

normanr opened this issue Mar 16, 2020 · 4 comments

Comments

@normanr
Copy link

normanr commented Mar 16, 2020

Currently SOA, NS, TXT, and MX records are returned for any name, but they should probably be restricted to the root domain only.

@cunnie
Copy link
Owner

cunnie commented Dec 12, 2020

Hi @normanr ,

Help me understand how this affects you. What's the downside of returning SOA, NS, TXT, and MX records?

The server is under active development, and the behavior is fluid (I'm willing to make changes).

On another note, I'm implementing a set of changes to return a richer set of resources for the root domain "sslip.io" (especially w.r.t. TXT & MX records) and a leaner set for all other queries (no TXT, MX record pointing to itself).

@normanr
Copy link
Author

normanr commented Dec 13, 2020

I forget the exact reason why, I think it was just a "would be nice to have clean data" and not any breaking reason. MX records are "fixed" with 0b9ee93. The discussion with respect to NS/TXT records is in #6.

@cunnie
Copy link
Owner

cunnie commented Dec 14, 2020

@normanr Thank you so much for browsing my commit history! I am impressed.

So let me ask you this: should I remove MX records for everything except the root domain sslip.io itself? Right now I'm returning an MX record to every query pointing to itself:

dig +short mx 127.0.0.1.sslip.io @ns-aws.nono.io

returns an MX records of 127.0.0.1.sslip.io. with a preference of zero, but I'm thinking of ditching that behavior and simply returning nothing.

@normanr
Copy link
Author

normanr commented Dec 14, 2020

I think the behavior as is currently implemented is fine. I opened the request back in March when the behavior of the shell script was to return protonmail records for all MX requests.

@normanr normanr closed this as completed Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants