Add software description to setup.py
#2582
Conversation
setup.py
Outdated
| Programming Language :: Python :: 2 | ||
| Programming Language :: Python :: 2.7 |
There was a problem hiding this comment.
Shouldn't you add these two lines only when backporting to v6? In master/v7 the support for PY2 is dropped.
There was a problem hiding this comment.
Thanks, I'll add it in the backport.
Co-Authored-By: Toshiki Kataoka <tos.lunar@gmail.com>
|
I fixed. |
setup.py
Outdated
| @@ -146,6 +166,13 @@ def reduce_requirements(key): | |||
| author_email='tokui@preferred.jp', | |||
| url='https://docs-cupy.chainer.org/', | |||
| license='MIT License', | |||
| download_url="https://pypi.org/project/cupy/", | |||
There was a problem hiding this comment.
It seems that other projects use this field as a link to tarballs.
https://sherif.io/2016/09/30/Python-package-with-GitHub-PyPI.html#add-tarball-download-url-to-setuppy
But it's not required and is not used even in pypa's official example project. So how about removing unless if you need some reason to include this?
There was a problem hiding this comment.
OK, I will remove this line.
kmaehashi
added
cat:install
Co-Authored-By: Kenichi Maehashi <webmaster@kenichimaehashi.com>
|
I fixed. |
kmaehashi
added
st:test-and-merge
|
pfnCI, test this please. |
|
Successfully created a job for commit 9ccaf35: |
|
@kmaehashi This pull-request is marked as |
|
pfnCI, test this please. |
|
Successfully created a job for commit 9ccaf35: |
|
Jenkins CI test (for commit 9ccaf35, target branch master) succeeded! |
Add software description to setup.py
toslunar
changed the title
setup.py
|
Jenkins CI test (for commit 9ccaf35, target branch master) failed with status FAILURE. |
This PR provides rich information for PyPI.