Use mira_publication_workflow and hyrax actor stack for self-deposit … #248
Conversation
|
This is a big PR, sorry about that. |
…contributions Add feature test for capstone contribute Persist depositor to fedora object (enables "my works" behavior) Pdfs created via contribute should use default admin set and mira_publication_workflow Use AttachFilesToWorkJob to attach uploaded file Creation of default admin set now happens in db:seed, which is run in db:setup Using Tufts::WorkflowSetup.setup instead of creating default admin set directly will avoid intermittent test failures Enable customized notifications
bess
force-pushed
the
invoke_workflow_from_form
branch
from
77f16f4
to
46830cc
Compare
|
@no-reply afaict, this is failing for reasons unrelated to this PR. Would you please take a look? If I'm wrong I'm happy to revise. |
|
The failures look like they are javascript related. This is ringing a bell for me from earlier in the project. @little9: do you recall what we did the last time this popped up? |
|
I'll rebase after the merge of #253 to ensure we're passing. Still expecting to finish review this afternoon. |
| @@ -0,0 +1,15 @@ | |||
| class CreateJobIoWrappers < ActiveRecord::Migration[5.0] | |||
There was a problem hiding this comment.
I didn't catch that this was in here before I submitted #255. I think we'll want to rebase this on that, so the migration has its own commit.
| @@ -9,7 +9,8 @@ | |||
|
|
|||
| module Epigaea | |||
| class Application < Rails::Application | |||
| config.active_job.queue_adapter = :sidekiq | |||
| # config.active_job.queue_adapter = :sidekiq | |||
| config.active_job.queue_adapter = :inline | |||
There was a problem hiding this comment.
Can you say something about this? I'm thinking this looks like an artifact of your development env?
There was a problem hiding this comment.
You are correct. Whoops. :(
| end | ||
|
|
||
| # The Users who have an admin role | ||
| # @return [<Array>::User] an Array of Hyrax::User objects |
There was a problem hiding this comment.
It think the correct Yard collection annotation syntax for this is [Array<User>]. I'm not too worried about getting a fix in for merge.
|
This PR was superseded. |
…contributions
Add feature test for capstone contribute
Persist depositor to fedora object (enables "my works" behavior)
Pdfs created via contribute should use default admin set and mira_publication_workflow
Use AttachFilesToWorkJob to attach uploaded file
Creation of default admin set now happens in db:seed, which is run in db:setup
Using Tufts::WorkflowSetup.setup instead of creating default admin set directly will avoid intermittent test failures
Enable customized notifications
Fixes #245
Fixes #3
Fixes #5
Fixes #235