fix vs2019 warnings: conversion from 'bit' to 'bool'

[gvollant]

when use a bit variable to call function which need a bool, Visual Studio 2019 display:
warning C4244: 'function': conversion from 'bit' to 'bool', possible loss of data

This simple PR just add a (bool) cast

[bagder]

./ftp.c:3609:81: warning: Longer than 79 columns (LONGLINE)
         result = ftp_nb_type(conn, (bool)data->set.prefer_ascii, FTP_RETR_TYPE);

[bagder]

See also #4189 which is basically a duplicate. Can we first figure out how we can get these warnings to show up in the existing CI builds?

[gvollant]

It seem there is no VS2019 build on the appveyor build. PEhaps you can add a VS2019 build, or migrate one from VS2017 to 2019 De : Daniel Stenberg [mailto:notifications@github.com] Envoyé : jeudi 19 septembre 2019 14:08 À : curl/curl Cc : gvollant; Author Objet : Re: [curl/curl] fix warning vs2019 (#4379) See also #4189 <#4189> which is basically a duplicate. Can we first figure out how we can get these warnings to show up in the existing CI builds? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4379?email_source=notifications&email_token=AAIKFN4PPPHKZNLTYCYY3ULQKNTQRA5CNFSM4IYJ24RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7DHKNA#issuecomment-533099828> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIKFN66LXKVRK4KKTJAW4DQKNTQRANCNFSM4IYJ24RA> . <https://github.com/notifications/beacon/AAIKFNZ7IBNM2AOLGHGH22TQKNTQRA5CNFSM4IYJ24RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7DHKNA.gif>

[gvollant]

I'm surprised that checks are not sucessful with only cast

[bagder]

Looks like the regular false positives we get...

[bagder]

The coming VS2019 builds in #4383 show the problems this PR aims to fix.

[bagder]

I'm not a fan of typecasts, but I can't see any better way to address these warnings...

[jay]

try using _Bool for bit type

[bagder]

That's a good idea!