Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log observed time from Retry-After #4498

Closed
wants to merge 1 commit into from

Conversation

@stain
Copy link
Contributor

stain commented Oct 16, 2019

.. if the Retry-After header overrides the --retry-delay parameter or the default of 1.

Augments #3794 and #4465 so that the logging matches the actual initial sleep that observes Retry-After header.

Currently if Retry-After: 60 then curl --retry 5 will correctly sleep 60 seconds, but still misleadingly log:

Transient problem: ...  Will retry in 1 seconds. 5 retries left.
.. if it overrides the parameter/default
@jay jay closed this in fe5c246 Oct 16, 2019
@jay jay added the cmdline tool label Oct 16, 2019
@jay

This comment has been minimized.

Copy link
Member

jay commented Oct 16, 2019

Thanks

stain added a commit to stain/ro-index-paper that referenced this pull request Nov 7, 2019
incorporates curl/curl#4465 and curl/curl#4498
@stain stain deleted the stain:http-retry-after-logging branch Nov 7, 2019
stain added a commit to stain/ro-index-paper that referenced this pull request Nov 7, 2019
This build is based on
7c2f8c0.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/stain/ro-index-paper/builds/135475492
https://travis-ci.com/stain/ro-index-paper/jobs/254097570

[ci skip]

The full commit message that triggered this build is copied below:

Use latest curl release 7.67.7

incorporates curl/curl#4465 and curl/curl#4498
stain added a commit to stain/ro-index-paper that referenced this pull request Nov 7, 2019
This build is based on
7c2f8c0.

This commit was created by the following Travis CI build and job:
https://travis-ci.com/stain/ro-index-paper/builds/135475492
https://travis-ci.com/stain/ro-index-paper/jobs/254097570

[ci skip]

The full commit message that triggered this build is copied below:

Use latest curl release 7.67.7

incorporates curl/curl#4465 and curl/curl#4498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.