Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sha256: Added TLS library based implementations #4956

Closed
wants to merge 6 commits into from

Conversation

@captain-caveman2k
Copy link
Member

@captain-caveman2k captain-caveman2k commented Feb 20, 2020

Implemented SHA256 support through the following TLS libraries rather than limiting to either OpenSSL or our own native implementation:

  • GNU TLS Nettle
  • GNU TLS gcrypt
  • mbed TLS
lib/sha256.c Outdated Show resolved Hide resolved
lib/sha256.c Show resolved Hide resolved
@captain-caveman2k captain-caveman2k force-pushed the captain-caveman2k:vtls_sha256 branch 2 times, most recently from f13f791 to 8f78b5d Feb 20, 2020
@captain-caveman2k captain-caveman2k force-pushed the captain-caveman2k:vtls_sha256 branch 4 times, most recently from 2f16bb4 to 89b47d1 Feb 23, 2020
@captain-caveman2k captain-caveman2k force-pushed the captain-caveman2k:vtls_sha256 branch from 89b47d1 to 1851877 Feb 26, 2020
@captain-caveman2k captain-caveman2k force-pushed the captain-caveman2k:vtls_sha256 branch from 1851877 to 523e188 Feb 27, 2020
@captain-caveman2k captain-caveman2k force-pushed the captain-caveman2k:vtls_sha256 branch from 523e188 to 1bc2778 Mar 1, 2020
@bagder
Copy link
Member

@bagder bagder commented Mar 3, 2020

This PR merge introduced test 1610 failures on macos without TLS:

https://dev.azure.com/daniel0244/curl/_build/results?buildId=902&view=logs&j=12352f4a-0d11-5197-0393-8a084f220de5&t=b606a952-a560-5f0c-07fb-88af8a444425&l=2903

We're < 24 hours from release. This needs to be fixed ASAP.

@bagder bagder reopened this Mar 3, 2020
bagder added a commit that referenced this pull request Mar 3, 2020
This reverts commit 4feb38d (from #4956)

That commit broke test 1610 on macos builds without TLS.
@bagder
Copy link
Member

@bagder bagder commented Mar 3, 2020

we handle the single reverted commit in #5027, as it seems to be enough to get back to green macos builds

@bagder bagder closed this Mar 3, 2020
bagder added a commit that referenced this pull request Mar 3, 2020
This reverts commit 4feb38d (from #4956)

That commit broke test 1610 on macos builds without TLS.

Closes #5027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.