Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtests: make cleardir() erase dot files #5838

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

bagder commented Aug 21, 2020

Because test cases might use dot files.

(#5837 adds a test case with a dot file in there)

Because test cases might use dot files.
@bagder bagder added the tests label Aug 21, 2020
@emilengler
Copy link
Contributor

emilengler commented Aug 21, 2020

I disagree on that change. We should not delete files without any feedback. Instead I would suggest adding a new section to a testcase which specifies which files to clean up

@bagder
Copy link
Member Author

bagder commented Aug 21, 2020

First, it already deletes files without feedback. It just skips the ones with a leading dot right now - to avoid problem with . and ... But I have new tests incoming that create temporary dot files in log/ and I expected them to get removed just like any other file we (temporarily) create in there.

I would suggest adding a new section to a testcase which specifies which files to clean up

What scenario are you visioning this will help with?

@emilengler
Copy link
Contributor

emilengler commented Aug 22, 2020

What scenario are you visioning this will help with?

Some people might be saving files (as a backup) with making it a dot file

@bagder
Copy link
Member Author

bagder commented Aug 22, 2020

in the tests/log directory?

@emilengler
Copy link
Contributor

emilengler commented Aug 22, 2020

Maybe. A huge advantage of dotfiles is that these files don't get deleted if you provide wildcards for example

@dfandrich
Copy link
Collaborator

dfandrich commented Aug 22, 2020

@bagder
Copy link
Member Author

bagder commented Aug 22, 2020

I think having the test suite work nicely and conveniently is way more important than taking precautions against possibly removing important files a crazy person saves in the test suite's junk folder!

@bagder bagder closed this in d71ac67 Aug 23, 2020
@bagder bagder deleted the bagder/runtests-rm-dotfiles branch Aug 23, 2020
@bagder bagder mentioned this pull request Aug 24, 2020
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.