/ curl Public
configure: fail if '--without-ssl' has been set together with an explicit parameter for an ssl lib #9414
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
As part of packaging 7.85.0 on Debian, I noticed a build issue due to our packaging using the wrong configure flags, it would set both
--with-gnutls, this would result in the build being marked as a MultiSSL one.
I have addressed the issue by removing the wrong parameter (
--without-ssl), which I believe was added with the intention of behaving like
--without-openssl(though this parameter is not available), but it looks like it's a good idea to make the configure script stricter to avoid this from happening altogether, so I figure you might be interested in this change.
Commit description below:
A side effect of a previous change to configure (576e507)
exposed a non-critical issue that can happen if configure is called
with both '--without-ssl' and some parameter setting the use of a
ssl library (e.g. --with-gnutls). The configure script would end
up assuming this is a MultiSSL build, due to the way the case
statement is written.
I have changed the order of the variables in the string concatenation
for the case statement and also tweaked the options so that
--without-ssl never turns the build into a MultiSSL one and
also clearly stating that there are conflicting parameters
if the user sets it like described above.