Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: fail if '--without-ssl' has been set together with an explicit parameter for an ssl lib #9414

Closed

Conversation

samueloph
Copy link
Contributor

@samueloph samueloph commented Sep 1, 2022

As part of packaging 7.85.0 on Debian, I noticed a build issue due to our packaging using the wrong configure flags, it would set both --without-ssl and --with-nss or --with-gnutls, this would result in the build being marked as a MultiSSL one.

I have addressed the issue by removing the wrong parameter (--without-ssl), which I believe was added with the intention of behaving like --without-openssl (though this parameter is not available), but it looks like it's a good idea to make the configure script stricter to avoid this from happening altogether, so I figure you might be interested in this change.

Commit description below:
A side effect of a previous change to configure (576e507)
exposed a non-critical issue that can happen if configure is called
with both '--without-ssl' and some parameter setting the use of a
ssl library (e.g. --with-gnutls). The configure script would end
up assuming this is a MultiSSL build, due to the way the case
statement is written.

I have changed the order of the variables in the string concatenation
for the case statement and also tweaked the options so that
--without-ssl never turns the build into a MultiSSL one and
also clearly stating that there are conflicting parameters
if the user sets it like described above.

…icit parameter for an ssl lib

 A side effect of a previous change to configure (576e507)
 exposed a non-critical issue that can happen if configure is called
 with both '--without-ssl' and some parameter setting the use of a
 ssl library (e.g. --with-gnutls). The configure script would end
 up assuming this is a MultiSSL build, due to the way the case
 statement is written.

 I have changed the order of the variables in the string concatenation
 for the case statement and also tweaked the options so that
 --without-ssl never turns the build into a MultiSSL one and
 also clearly stating that there are conflicting parameters
 if the user sets it like described above.
bagder
bagder approved these changes Sep 4, 2022
@bagder bagder added the build label Sep 4, 2022
@bagder
Copy link
Member

bagder commented Sep 4, 2022

Thanks!

@bagder bagder closed this in 7d69924 Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants