-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail with out IDN #184
Comments
I ran into this as well when compiling libcurl as a static library on an ubuntu install that did not have libidn2-dev installed. I just installed the necessary package to get around it, but having a way to see what feature flags are enabled and be able to adjust what tests are run accordingly could be nice |
Ah yes. We need to poll the used libcurl version for IDN support (using curl_version_info) and probably output that info somehow so that we can figure that out and then avoid those tests... |
Would it make sense to just print the entirety of |
Printing the feature names on a separate line like curl has could be parsed into an array or list in test.py and compared against an array in the json of features required by a given test |
excellent, that's what I was thinking as well. |
Maybe have a prefix at the beginning of the line such as "libcurl features: " to make sure the user is aware that they are inherited from libcurl, and not necessarily directly related to trurl? |
I think we should only show features that are relevant for trurl, which for now only is IDN. Otherwise we will show a very long list of things that are irrelevant. We could possibly convert some of our libcurl version-dependent things to instead become named features: |
It is possible to have a recent version of curl installed without IDN support, so the tests fail.
I was playing around with getting trurl to run on a fresh FreeBSD install, and the curl version packaged by Freebsd didn't ship with IDN enabled. Note that it is curl 8.0.1. #164 added support for skipping tests based on the minimum version, but IDN (and other features) may need to be explicitly defined for the punycode tests.
The text was updated successfully, but these errors were encountered: