Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle special characters better #14

Open
3 tasks
curtisy1 opened this issue Mar 22, 2022 · 0 comments
Open
3 tasks

Handle special characters better #14

curtisy1 opened this issue Mar 22, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@curtisy1
Copy link
Owner

Currently, only a few characters are escaped and sanitized. This is because they appeared in the sample I was testing with at work. However, there's probably a bunch of other evil characters out there the generator should handle (how about ?, !, comma, ', ", <,>) to name just a few

  • Check how the official resx ResourceGenerator does escape these. Get at least feature parity (no code stealing)
  • Every breaking character gets replaced with a _. The ResourceManager should be able to find both variants (e.g. for JS parsing)
  • How do we deal with exotic characters or emojis? Are these even supported in resx? I know Csharp does not support them, so experiment and provide as much support as possible
@curtisy1 curtisy1 self-assigned this Mar 22, 2022
@curtisy1 curtisy1 added the enhancement New feature or request label Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant