fix: in-app missing event #259

Shahroz16 · 2023-02-03T09:53:34Z

Context: https://customerio.slack.com/archives/C036FTE6UJ0/p1675374046990879

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

Assign members of your team to review the pull request.
Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
Wait until the pull request has been reviewed and approved by a teammate
After pull request is approved, and you determine it's ready add the label "Ready to merge" to the pull request. A bot will squash and merge the pull request for you after the label is added.

ami-oss-ci · 2023-02-03T09:53:49Z

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.
fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.
docs: - This pull request is making documentation changes, only.
refactor: - A change was made that doesn't fix a bug or add a feature.
test: - Adds missing tests or fixes broken tests.
style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)
perf: - Changes improve performance of the code.
build: - Changes to the build system (maven, npm, gulp, etc)
ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)
chore: - Other changes to project that don't modify source code or test files.
revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

codecov · 2023-02-03T09:57:30Z

Codecov Report

Merging #259 (aede4e6) into develop (3cd9cc9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #259   +/-   ##
========================================
  Coverage    56.11%   56.11%           
========================================
  Files          103      103           
  Lines         1153     1153           
========================================
  Hits           647      647           
  Misses         506      506

Impacted Files	Coverage Δ
.../MessagingInApp/MessagingInAppImplementation.swift	`78.57% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sources/MessagingInApp/MessagingInAppImplementation.swift

levibostian · 2023-02-03T16:26:55Z

Sources/MessagingInApp/MessagingInAppImplementation.swift

-        if let deliveryId = getDeliveryId(from: message) {
-            // the state of the SDK does not change if adding this queue task isn't successful so ignore result
-            _ = queue.addTrackInAppDeliveryTask(deliveryId: deliveryId, event: .clicked)
+        if action != "gist://close" {


To see if I am understanding this correctly, the main reason for this change is that we want to make sure that the event listener is called even if the action was gist://close?

levibostian · 2023-02-03T16:27:30Z

Tests/MessagingInApp/MessagingInAppImplementationTest.swift

@@ -167,4 +167,25 @@ class MessagingInAppImplementationTest: UnitTest {
        messagingInApp.action(message: givenGistMessage, currentRoute: .random, action: .random, name: .random)
        XCTAssertEqual(eventListenerMock.messageActionTakenCallsCount, 2)
    }
+
+    func test_eventListeners_expectActionListenerForCloseAction() {


Suggested change

func test_eventListeners_expectActionListenerForCloseAction() {

func test_eventListeners_givenCloseAction_expectListenerEvent() {

I think this explains the test a little better.

## [2.1.0-beta.1](2.0.4...2.1.0-beta.1) (2023-02-07) ### Features * add in-app event listener ([#211](#211)) ([737d43b](737d43b)) * in-app feature no longer requires orgId ([#252](#252)) ([acd12da](acd12da)) ### Bug Fixes * added reusable code for wrapper SDKs ([#247](#247)) ([36adf15](36adf15)) * in-app missing event ([#259](#259)) ([43b3e97](43b3e97)) * modify in-app event listener action parameters to new name ([#255](#255)) ([b46528a](b46528a)) * region visibility modifier to be used by wrappers ([#260](#260)) ([f0edfbc](f0edfbc)) * update the gist version in podspec ([#256](#256)) ([5451488](5451488))

## [2.1.0](2.0.6...2.1.0) (2023-02-22) ### Features * add in-app event listener ([#211](#211)) ([737d43b](737d43b)) * in-app feature no longer requires orgId ([#252](#252)) ([acd12da](acd12da)) ### Bug Fixes * access modifier for metric ([#263](#263)) ([e641982](e641982)) * added reusable code for wrapper SDKs ([#247](#247)) ([36adf15](36adf15)) * in-app missing event ([#259](#259)) ([43b3e97](43b3e97)) * modify in-app event listener action parameters to new name ([#255](#255)) ([b46528a](b46528a)) * region visibility modifier to be used by wrappers ([#260](#260)) ([f0edfbc](f0edfbc)) * update the gist version in podspec ([#256](#256)) ([5451488](5451488))

github-actions · 2023-02-22T20:12:40Z

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Shahroz16 added 2 commits February 3, 2023 14:47

updated action method to not skip close event

4eaa57d

lint

f2a9c7c

Shahroz16 requested a review from a team February 3, 2023 09:54

Shahroz16 added 2 commits February 3, 2023 16:35

updated test

d93b534

lint

c26d612

levibostian approved these changes Feb 3, 2023

View reviewed changes

pr suggestions

aede4e6

Shahroz16 merged commit 43b3e97 into develop Feb 4, 2023

Shahroz16 deleted the shahroz/fix-in-app-missing-event branch February 4, 2023 08:39

github-actions bot added the released label Feb 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: in-app missing event #259

fix: in-app missing event #259

Shahroz16 commented Feb 3, 2023

ami-oss-ci commented Feb 3, 2023 •

edited

Loading

Examples:

codecov bot commented Feb 3, 2023 •

edited

Loading

levibostian Feb 3, 2023

Shahroz16 Feb 4, 2023

levibostian Feb 3, 2023

github-actions bot commented Feb 22, 2023

	func test_eventListeners_expectActionListenerForCloseAction() {
	func test_eventListeners_givenCloseAction_expectListenerEvent() {

fix: in-app missing event #259

fix: in-app missing event #259

Conversation

Shahroz16 commented Feb 3, 2023

ami-oss-ci commented Feb 3, 2023 • edited Loading

Examples:

codecov bot commented Feb 3, 2023 • edited Loading

Codecov Report

levibostian Feb 3, 2023

Choose a reason for hiding this comment

Shahroz16 Feb 4, 2023

Choose a reason for hiding this comment

levibostian Feb 3, 2023

Choose a reason for hiding this comment

github-actions bot commented Feb 22, 2023

ami-oss-ci commented Feb 3, 2023 •

edited

Loading

codecov bot commented Feb 3, 2023 •

edited

Loading