fix: display in-app messages with page rules set and kill/re-open app #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of: https://linear.app/customerio/issue/MBL-373/[bug]-in-app-messages-do-not-show-on-ios-if-page-rules-are-enabled-and Persist the queue of in-app messages to disk on iOS, similar to the existing implementation on Android and web platforms. Testing: * Automated tests have been written and will be introduced in a future PR to keep the amount of changes low in this PR. The SDK is not setup for testing this code easily so some test setup code needs added first. Reviewer notes: * I implemented a network-level HTTP response body cache, similar to the Android and web SDKs. I considered caching the `MessageQueueManager` local message queue, but it required more code changes then this. I like the network-level approach since this is a requirement of the SDK based on the HTTP communication with the Gist backend server.
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report between this PR and the main branch |
This was referenced Jun 21, 2024
Shahroz16
approved these changes
Jun 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #746 +/- ##
==========================================
+ Coverage 61.05% 63.19% +2.13%
==========================================
Files 140 140
Lines 3962 3994 +32
==========================================
+ Hits 2419 2524 +105
+ Misses 1543 1470 -73 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
## [3.3.1](3.3.0...3.3.1) (2024-06-25) ### Bug Fixes * display in-app messages with page rules set and kill/re-open app ([#746](#746)) ([cfae57d](cfae57d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: https://linear.app/customerio/issue/MBL-373/[bug]-in-app-messages-do-not-show-on-ios-if-page-rules-are-enabled-and
Persist the queue of in-app messages to disk on iOS, similar to the existing implementation on Android and web platforms.
Testing:
Reviewer notes:
MessageQueueManagerlocal message queue, but it required more code changes then this. I like the network-level approach since this is a requirement of the SDK based on the HTTP communication with the Gist backend server.