Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for legacy target target framework #72

Open
maksimkim opened this issue Jul 19, 2021 · 7 comments
Open

Drop support for legacy target target framework #72

maksimkim opened this issue Jul 19, 2021 · 7 comments

Comments

@maksimkim
Copy link
Contributor

Seems like explicit support for net451,net471,netcore2.1,netcore3.1 complicates dependency management.
Does it make sense to completely drop support for net451 and support the rest through netstandard 2.0?
So list of supported versions will reduce to netstanard2.0, netstandard2.1, net5.0.

@cuteant
Copy link
Owner

cuteant commented Jul 20, 2021

Windows desktop applications(winforms/wpf) isn't fully supported in .NET Core, starting with the .NET 5.0 release, it’s not a problem anymore.
so there is really no need to keep support for .netfx
😃
'dotnetty-common/Handlers' module : still need to continue to support .net core 3.1

@maksimkim
Copy link
Contributor Author

Is this because of alpn on sslstream?

@cuteant
Copy link
Owner

cuteant commented Jul 20, 2021

Yeah

@maksimkim
Copy link
Contributor Author

But isn't it available in netstandard2.1?

@cuteant
Copy link
Owner

cuteant commented Jul 20, 2021

@cuteant
Copy link
Owner

cuteant commented Jul 20, 2021

what I thought was to provide a unified impl(for encoding/span) that could be called by dotnetty.buffer in every targetframework......
so I copied some code from corefx

@cuteant
Copy link
Owner

cuteant commented Jul 20, 2021

and also , like this code:

#if NETCOREAPP || NETSTANDARD_2_0_GREATER
output.Write(_GetReadableSpan(index, length));
#else

is able to execute in netcoreapp2.1 but not in .net standard 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants