Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to kornia #21

Closed
ducha-aiki opened this issue Jul 7, 2023 · 4 comments
Closed

PR to kornia #21

ducha-aiki opened this issue Jul 7, 2023 · 4 comments

Comments

@ducha-aiki
Copy link
Contributor

Hi,

I have created a PR to kornia kornia/kornia#2436
Please tell me, if you have any feedback or objections.

Best, Dmytro
@sarlinpe
Copy link
Member

sarlinpe commented Jul 7, 2023

Fantastic, thank you Dmytro! We will make some changes to the interface in the next days so better wait and update the PR later.

@sarlinpe
Copy link
Member

@ducha-aiki We've made several updates and don't expect new ones for now. Thanks again!

@Phil26AT
Copy link
Collaborator

@ducha-aiki thank you for creating this PR, it would be great to have LightGlue in kornia! We also removed the einops dependency in PR #25.

@ducha-aiki
Copy link
Contributor Author

@skydes @Phil26AT Thank you! I will update the PR and merge into kornia tomorrow or Thursday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ducha-aiki @sarlinpe @Phil26AT