Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use c++14 in CMake build by default #20

Merged
merged 1 commit into from
Nov 17, 2018
Merged

Use c++14 in CMake build by default #20

merged 1 commit into from
Nov 17, 2018

Conversation

antoinealb
Copy link
Member

I think we can safely use that, everyone has a decent compiler nowadays, do we ?

I will update it on Pypi once it gets merged.

SyrianSpock
SyrianSpock approved these changes Nov 16, 2018
View reviewed changes
Copy link
Member

@SyrianSpock SyrianSpock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable, although some day I'd like to kill packager

@antoinealb
Copy link
Member Author

Me too, me too. But it does not appear to be anytime soon, unless we decide to spend a lot of time converting our build system.

@antoinealb antoinealb merged commit a6b95f3 into master Nov 17, 2018
@antoinealb antoinealb deleted the std-cxx-14 branch November 17, 2018 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyrianSpock SyrianSpock SyrianSpock approved these changes

@msplr msplr Awaiting requested review from msplr

@Lu-ni Lu-ni Awaiting requested review from Lu-ni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoinealb @SyrianSpock