Store touchscreen config #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you document somewhere how those values can be obtained? |
antoinealb
reviewed
Nov 15, 2018
master-firmware/src/config.c
Outdated
| parameter_scalar_declare_with_default(&screen.ay, &screen.ns, "ay", 0); | ||
| parameter_scalar_declare_with_default(&screen.bx, &screen.ns, "bx", 0); | ||
| parameter_scalar_declare_with_default(&screen.by, &screen.ns, "by", 0); | ||
| parameter_scalar_declare_with_default(&screen.cx, &screen.ns, "cx", 0); |
There was a problem hiding this comment.
Might be better not to have any defaults as the default value of 0. will cause the screen to act in weird ways. I would prefer to have an assert fail.
Lu-ni
force-pushed
the
store-touchscreen-config
branch
from
8e774c7
to
a9750d6
Compare
Lu-ni
force-pushed
the
store-touchscreen-config
branch
from
a9750d6
to
b5111e9
Compare
|
Tested and working now |
antoinealb
approved these changes
Nov 19, 2018
Where should I put the file ? A README.md in the gui folder (../src/gui/) ? |
|
Yes I think this would work. |
1 similar comment
|
Yes I think this would work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each touchscreen need to have his own configuration to work well.
Next step will be to implement touch screen calibration.