Implement trivial inverses for some more atoms #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edge case in which a user takes a sum/cumsum of a scalar atom.
|
Some context: The basic issue is that DQCP allows the root of an expression tree to be transformed by monotone increasing (or decreasing) real functions. The reduction just inverts these functions. Looks like we missed a few inverses in the original implementation. This part of the grammar is silly, though, because all such a transformation does is yield an equivalent problem. We included it for completeness, but if I were to do it again I'd not allow monotone transformations. Allowing them adds little value, but adds significant maintenance burden ... Perhaps something for CVXPY 2.0 ... |
cvxpy/reductions/dqcp2dcp/inverse.py
Outdated
| import numpy as np | ||
|
|
||
| INVERTIBLE = set( | ||
| [atoms.ceil, atoms.floor, NegExpression, atoms.exp, atoms.log, atoms.log1p, | ||
| atoms.logistic, atoms.power, atoms.abs]) | ||
| atoms.logistic, atoms.power, atoms.abs, atoms.cumsum]) |
There was a problem hiding this comment.
Added some comments.
SteveDiamond
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge case in which a user takes a sum/cumsum of a scalar atom.