[CI] Build cvxpy-base (Issue 1478) #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add actions for building cvxpy-base * Make sed work on MacOS * Check python version * Remove 'need' * Fix * use python3 * Test if conda sets up python * Upload to test pypi * Specify python version explicitly * Different flag to upload to pypi * Use python3 for twine call * retry without default shell * Add shell to additional envs * setup python action * fix * Final changes
phschiele
commented
Sep 29, 2021
Comment on lines
+146
to
+149
| sed -i.bak -e "s/name='cvxpy',/name='cvxpy-base',/g" setup.py | ||
| sed -i.bak '/osqp >= /d' setup.py | ||
| sed -i.bak '/ecos >= /d' setup.py | ||
| sed -i.bak '/scs >= /d' setup.py |
There was a problem hiding this comment.
This is basically the complete logic and the assumptions made about the contents of setup.py.
There was a problem hiding this comment.
So basically are you removing the solvers from the dependencies?
There was a problem hiding this comment.
Precisely 👍🏻 I thought it would be easier to maintain compared to having a second file.
phschiele
commented
Sep 29, 2021
| CIBW_BUILD: "cp3${{env.PYTHON_SUBVERSION}}-*" | ||
| CIBW_SKIP: "*-win32 *-manylinux_i686" | ||
| CIBW_MANYLINUX_X86_64_IMAGE: manylinux_2_24 | ||
| uses: joerick/cibuildwheel@v1.11.0 |
There was a problem hiding this comment.
Small technical detail: the wheels do not allow hyphens, so the wheel file is automatically renamed to cvxpy_base*. This has no effect on the pip installation.
SteveDiamond
requested review from
akshayka and
rileyjmurray
and removed request for
akshayka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: #1478
@SteveDiamond as discussed, this additional action publishes
cvxpy-baseon PyPi, i.e. without any solvers preinstalled.I have done a test run on TestPyPI, which worked well.
It can be tried using:
It would only run with the next tagged release, but one could upload the current 1.1.15 version by disabling the
${{env.DEPLOY == 'True'}}checks for one commit.I have added a small section to the docs as well.