Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Skip XPRESS test #1838

Merged
merged 1 commit into from
Jul 22, 2022
Merged

[CI] Skip XPRESS test #1838

merged 1 commit into from
Jul 22, 2022

Conversation

phschiele
Copy link
Collaborator

Description

Failing test creates downstream issues like no coverage reports.
Issue link (if applicable): #1815

Type of change

  • New feature (backwards compatible)
  • New feature (breaking API changes)
  • Bug fix
  • Other (Documentation, CI, ...)

Contribution checklist

  • Add our license to new files.
  • Check that your code adheres to our coding style.
  • Write unittests.
  • Run the unittests and check that they’re passing.
  • Run the benchmarks to make sure your change doesn’t introduce a regression.

@github-actions
Copy link

Benchmarks that have stayed the same:

   before           after         ratio
 [dc54c181]       [eafac54b]
      37.7±0s          40.1±0s     1.06  cvar_benchmark.CVaRBenchmark.time_compile_problem
      4.81±0s          5.01±0s     1.04  simple_LP_benchmarks.SimpleFullyParametrizedLPBenchmark.time_compile_problem
      58.4±0s          57.9±0s     0.99  sdp_segfault_1132_benchmark.SDPSegfault1132Benchmark.time_compile_problem
      28.6±0s          28.2±0s     0.98  simple_LP_benchmarks.SimpleLPBenchmark.time_compile_problem
      29.1±0s          28.6±0s     0.98  qp_1611_benchmark.QP1611Benchmark.time_compile_problem
      2.14±0s          2.06±0s     0.96  simple_LP_benchmarks.SimpleScalarParametrizedLPBenchmark.time_compile_problem

@SteveDiamond SteveDiamond merged commit 594a640 into cvxpy:master Jul 22, 2022
SteveDiamond added a commit to tasseff/cvxpy that referenced this pull request Jul 27, 2022
@SteveDiamond
Merge remote-tracking branch 'origin/master' into tasseff/master
c4ba1ab 
* origin/master:
  Add new QpSolver and ConicSolver for COPT under CVXPY (cvxpy#1836)
  fix linter
  contribute a atomic operation of trace(inv(X)) (cvxpy#1822)
  Add Coverage and benchmark badges (cvxpy#1839)
  Skip XPRESS test (cvxpy#1838)
  Fix bug with diff (cvxpy#1835)
  fix cvxpy#1828 (cvxpy#1829)
SteveDiamond added a commit to r-barnes/cvxpy that referenced this pull request Aug 1, 2022
@SteveDiamond
Merge remote-tracking branch 'origin/master' into richard/fix_isrowmajor
178f67c 
* origin/master: (57 commits)
  fix linters (cvxpy#1851)
  fix link
  publish to web
  [CI] Bump macOS runner (cvxpy#1846)
  Add new QpSolver and ConicSolver for COPT under CVXPY (cvxpy#1836)
  fix linter
  contribute a atomic operation of trace(inv(X)) (cvxpy#1822)
  Add Coverage and benchmark badges (cvxpy#1839)
  Skip XPRESS test (cvxpy#1838)
  Fix bug with diff (cvxpy#1835)
  fix cvxpy#1828 (cvxpy#1829)
  Follow up with assume PSD (cvxpy#1820)
  Update finite_set.py
  Added feature mentioned in issue cvxpy#1695 (cvxpy#1754)
  Assume PSD argument to quad_form (cvxpy#1818)
  Added benchmarks workflow to benchmark the master branch of cvxpy and upload results (cvxpy#1798)
  COPT interface (cvxpy#1796)
  New workflow to make benchmarks run on PR commits (cvxpy#1810)
  [doc] Clarify that abs() supports complex numbers (cvxpy#1814)
  Add condition_number as a quasi-convex atom (cvxpy#1768)
  ...
@rileyjmurray rileyjmurray mentioned this pull request Nov 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveDiamond SteveDiamond SteveDiamond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phschiele @SteveDiamond