Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Remove packaging dependency #17

Merged
merged 2 commits into from
Feb 24, 2022
Merged

chore(deps): Remove packaging dependency #17

merged 2 commits into from
Feb 24, 2022

Conversation

TheRealKeto
Copy link
Contributor

This PR removes the redundant packaging dependency that ktool (currently) has. It's evident that such package is not needed; see the example below.

(venv) ~/Projects/ktool keto% python
Python 3.9.9 (main, Jan 21 2022, 10:41:38)
[Clang 13.0.0 (clang-1300.0.29.3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import json
>>> import urllib.request
>>>
>>> ktool_ver_test = "0.20.0"
>>> endpoint = "https://pypi.org/pypi/k2l/json"
>>>
>>> with urllib.request.urlopen(endpoint, timeout=1) as url:
...     data = json.loads(url.read().decode(), strict=False)
...
>>> ktool_new_ver = data.get("info").get("version")
>>> if ktool_ver_test < ktool_new_ver:
...     print("A new version is available!")
...     print("Wow, imagine using an entire library for this")
...
A new version is available!
Wow, imagine using an entire library for this
>>> print(ktool_ver_test)
0.20.0
>>> print(ktool_new_ver)
0.20.1
>>>

* Version checking works fine without it

Signed-off-by: TheRealKeto <therealketo@gmail.com>
Signed-off-by: TheRealKeto <therealketo@gmail.com>
@0cyn 0cyn merged commit 8f284db into 0cyn:master Feb 24, 2022
@TheRealKeto TheRealKeto deleted the remove/packaging branch February 24, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants