Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate #ifdefs from most source/headers #5

Closed
cxong opened this issue Jan 19, 2013 · 1 comment
Closed

Eliminate #ifdefs from most source/headers #5

cxong opened this issue Jan 19, 2013 · 1 comment
Assignees
@cxong
Labels
engine
Milestone
Polishing

Comments

@cxong
Copy link
Owner

cxong commented Jan 19, 2013

Code that depend on different build configs or platforms should be separated. Having two versions of the same code in the same functions makes maintenance hard. This is especially the case for modules such as sound.c.
@ghost ghost assigned cxong Jan 20, 2013
@cxong
Copy link
Owner Author

cxong commented Jan 20, 2013

Complete but not sure if windows build works, will need to test.

@cxong cxong closed this as completed Jan 20, 2013
@DavidKnight247 DavidKnight247 mentioned this issue Sep 4, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cxong cxong

Labels
engine
Projects
None yet
Milestone
Polishing
Development

No branches or pull requests
1 participant
@cxong