ssl.c unreachable code in PemToDer function

[petervas]

Hi,

in the following for loop the header and footer can never be assigned BEGIN_DSA_PRIV and END_DSA_PRIV, respectively.

    /* find header */
    for (;;) {
        headerEnd = XSTRNSTR((char*)buff, header, sz);

        if (headerEnd || type != PRIVATEKEY_TYPE) {
            break;
        } else if (header == BEGIN_RSA_PRIV) {
                   header =  BEGIN_PRIV_KEY;       footer = END_PRIV_KEY;
        } else if (header == BEGIN_PRIV_KEY) {
                   header =  BEGIN_ENC_PRIV_KEY;   footer = END_ENC_PRIV_KEY;
        } else if (header == BEGIN_ENC_PRIV_KEY) {
                   header =  BEGIN_EC_PRIV;        footer = END_EC_PRIV;
        } else if (header == BEGIN_ENC_PRIV_KEY) {
                   header =  BEGIN_DSA_PRIV;       footer = END_DSA_PRIV;
        } else
            break;
    }

There are two (header == BEGIN_ENC_PRIV_KEY) checks. It might be better if someone familiar with the code could have a look to clarify if this is intentional or maybe an issue.

[moisesguimaraes]

Hi Peter,

It should be BEGIN_EC_PRIV instead, thanks for the catch!