Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed garbled logging messages in PG connector #1192

Merged
merged 1 commit into from Apr 9, 2020
Merged

Conversation

sgnn7
Copy link
Contributor

@sgnn7 sgnn7 commented Apr 9, 2020

Some of the messages were using the non-formatted output with a
formatting string which was creating pretty unreadable logging output so
these have been fixed now.

What ticket does this PR close?

N/A

Where should the reviewer start?

What is the status of the manual tests?

Have you run the following manual tests to verify existing functionality continues to function as expected?

If this feature does not have any/sufficent automated tests, have you created/updated a folder in test/manual that includes:

  • An updated README with instructions on how to manually test this feature
  • Utility start and stop scripts to spin up and tear down the test environments
  • A test script to run some basic manual tests (optional; if does not exist, the README should have detailed instructions)

Links to open issues for related automated integration and unit tests

N/A

Links to open issues for related documentation (in READMEs, docs, etc)

N/A

Screenshots (if appropriate)

Some of the messages were using the non-formatted output with a
formatting string which was creating pretty unreadable logging output so
these have been fixed now.
@sgnn7 sgnn7 requested a review from a team as a code owner April 9, 2020 16:07
@codeclimate
Copy link

codeclimate bot commented Apr 9, 2020

Code Climate has analyzed commit 2fd6b3e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 48.2% (0.0% change).

View more on Code Climate.

@sgnn7 sgnn7 merged commit f627c90 into master Apr 9, 2020
@izgeri izgeri deleted the fix-pg-debug-messages branch April 9, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants