Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wb_supervisor_get_from_device function #2074

Merged
merged 13 commits into from
Aug 6, 2020
Merged

Add wb_supervisor_get_from_device function #2074

merged 13 commits into from
Aug 6, 2020

Conversation

stefaniapedrazzi
Copy link
Member

@stefaniapedrazzi stefaniapedrazzi commented Aug 4, 2020 •
edited

Address #1992:

  • Add C API function
  • Implement it in WbSupervisor
  • Add function in C++, Python, Java, Matlab
  • Add function in Ros default controller
  • Test new function in api/supervisor_node.wbt and languages/ros/complete_test.wbt
  • Add documentation
  • Add entry in changelog

Documentation
https://www.cyberbotics.com/doc/reference/supervisor?version=enhancement-supervisor-get-node-from-tag#wb_supervisor_node_get_from_device

@stefaniapedrazzi stefaniapedrazzi added the enhancement Implementation of a minor feature label Aug 4, 2020
@stefaniapedrazzi stefaniapedrazzi added this to the R2021a milestone Aug 4, 2020
@stefaniapedrazzi stefaniapedrazzi self-assigned this Aug 4, 2020
@omichel omichel changed the title Add wb_supervisor_get_from_device function Add wb_supervisor_get_from_device function Aug 5, 2020
@stefaniapedrazzi stefaniapedrazzi marked this pull request as ready for review August 6, 2020 06:14
@stefaniapedrazzi stefaniapedrazzi requested a review from a team August 6, 2020 07:01
omichel
omichel requested changes Aug 6, 2020
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a first code review.
I didn't yet checked the functionality.

docs/reference/changelog-r2021.md Outdated Show resolved Hide resolved
docs/reference/supervisor.md Outdated Show resolved Hide resolved
docs/reference/supervisor.md Show resolved Hide resolved
include/controller/cpp/webots/Supervisor.hpp Show resolved Hide resolved
stefaniapedrazzi and others added 2 commits August 6, 2020 10:36
@stefaniapedrazzi @omichel
Update docs/reference/changelog-r2021.md
e5535d4 
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
@stefaniapedrazzi @omichel
Update docs/reference/supervisor.md
3ac96b8 
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
omichel
omichel approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I checked that the wb_supervisor_node_get_selected() is still working.
I successfully ran the test suite on Windows on this branch.

@stefaniapedrazzi stefaniapedrazzi merged commit 8e5ebbb into develop Aug 6, 2020
@stefaniapedrazzi stefaniapedrazzi deleted the enhancement-supervisor-get-node-from-tag branch August 6, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omichel omichel omichel approved these changes

Assignees

@stefaniapedrazzi stefaniapedrazzi

Labels
enhancement Implementation of a minor feature
Milestone
R2021a
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefaniapedrazzi @omichel