Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Different GPS Messages for local and WGS 84 Coordinate Systems #2368

Merged
merged 10 commits into from Oct 22, 2020

Conversation

lukicdarkoo
Copy link
Member

@lukicdarkoo lukicdarkoo commented Oct 21, 2020

Description
This PR addresses #2158. We were publishing NavSatFix ROS messages even though these messages are reserved for WGS 84. We merge to develop because we introduce breaking changes.

Related Issues
#2158

Documentation
https://cyberbotics.com/doc/reference/gps?tab-language=ros&version=fix-ros-gps#gps-functions

Tasks

  • Change documentation
  • Add to changelog

@lukicdarkoo lukicdarkoo added the bug Something isn't working label Oct 21, 2020
@lukicdarkoo lukicdarkoo self-assigned this Oct 21, 2020
@lukicdarkoo lukicdarkoo added the test suite Start the test suite label Oct 21, 2020
@lukicdarkoo lukicdarkoo changed the title Publish different GPS messages for local and WGS 84 Coordinate Systems Publish Different GPS Messages for local and WGS 84 Coordinate Systems Oct 21, 2020
@lukicdarkoo lukicdarkoo marked this pull request as ready for review October 21, 2020 14:06
@lukicdarkoo lukicdarkoo requested a review from a team October 21, 2020 14:06
@DavidMansolino DavidMansolino added the test ros Start the ros test label Oct 21, 2020
Copy link
Member

@DavidMansolino DavidMansolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good, I just started the test ros.

docs/reference/changelog-r2021.md Outdated Show resolved Hide resolved
Co-authored-by: David Mansolino <mansolino.david@gmail.com>
Co-authored-by: David Mansolino <mansolino.david@gmail.com>
Copy link
Member

@DavidMansolino DavidMansolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test ros Start the ros test test suite Start the test suite
Development

Successfully merging this pull request may close these issues.

None yet

2 participants