Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python Display.imageNew and improve documentation #2443

Merged
merged 16 commits into from Nov 16, 2020

Conversation

stefaniapedrazzi
Copy link
Member

@stefaniapedrazzi stefaniapedrazzi commented Nov 9, 2020

Address #2441: improve documentation of the image format returned by the Camera API and how to display a Camera image in a Display.

Tasks:

  • specify image format in Camera section
  • add examples in Display section
  • add a warning in the Python API if the passed image has string format
    edit: fix free of invalid pointer in the Python API if the passed image has string format

@stefaniapedrazzi stefaniapedrazzi added the documentation Improve or fix the documentation (MD files only, no software development) label Nov 9, 2020
@stefaniapedrazzi stefaniapedrazzi added this to the R2020b.rev2 milestone Nov 9, 2020
@stefaniapedrazzi stefaniapedrazzi self-assigned this Nov 9, 2020
@stefaniapedrazzi
Copy link
Member Author

I could finally identify the error causing the crash when passing a string image data to the Python Camera.imageNew function.
The problem is that the string is freed but it should not (malloc is only executed in case of a list type):

%typemap(freearg) const void * {
free($1);
}

I'm checking but I'm not sure if there is a way to recognize if the const void * argument has been created from a list (with malloc) or from a string (no free required).

while(wb_robot_step(time_step) != -1) {
const unsigned char *data = wb_camera_get_image(camera);
if (data) {
WbImageRef ir = wb_display_image_new(display, width, height, data, WB_IMAGE_ARGB);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wb_camera_get_image returns data in BGRA format.
But to work correctly I have to set the wb_display_image_new format to ARGB.
This doesn't seem very intuitive for users.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inversion comes from this line:

((uint32_t *)i->image)[j] = img[j * 4] << 24 | img[j * 4 + 1] << 16 | img[j * 4 + 2] << 8 | img[j * 4 + 3];

For wb_camera_get_image input data in BGRA format the image pixel uint32_t is 0xbbggrraa.
But it seems that internally it is stored in little-endian because accessing the image bytes you get inversed values and inversed bytes are sent to Webots (here).

printf("pixel %02x %02x %02x %02x\n", ((unsigned char *)(i->image))[0], ((unsigned char *)(i->image))[1], ((unsigned char *)(i->image))[2], ((unsigned char *)(i->image))[3]);
# result for pixel data B=152(0x98) G=109(0x6d) R=90(0x5a) A=255(0xff)
# "pixel ff 5a 6d 98"

I fixed it locally and run the test suite and all the tests are still working correctly.
But I would fix this on the develop branch to prevent issues with user controllers.

@stefaniapedrazzi stefaniapedrazzi changed the title Improve documentation of Camera and Display APIs Fix Python Display.imageNew and improve documentation of Camera and Display APIs Nov 16, 2020
@stefaniapedrazzi stefaniapedrazzi changed the title Fix Python Display.imageNew and improve documentation of Camera and Display APIs Fix Python Display.imageNew and improve documentation Nov 16, 2020
@stefaniapedrazzi stefaniapedrazzi added test suite Start the test suite and removed documentation Improve or fix the documentation (MD files only, no software development) labels Nov 16, 2020
@stefaniapedrazzi stefaniapedrazzi added the documentation Improve or fix the documentation (MD files only, no software development) label Nov 16, 2020
@stefaniapedrazzi stefaniapedrazzi marked this pull request as ready for review November 16, 2020 13:52
@stefaniapedrazzi stefaniapedrazzi requested a review from a team November 16, 2020 13:52
@omichel omichel self-requested a review November 16, 2020 13:58
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I just have a few minor suggestions.
We shall now fix the develop branch with respect to the ARGB format.

docs/reference/camera.md Outdated Show resolved Hide resolved
docs/reference/display.md Outdated Show resolved Hide resolved
docs/reference/display.md Outdated Show resolved Hide resolved
docs/reference/display.md Outdated Show resolved Hide resolved
docs/reference/display.md Outdated Show resolved Hide resolved
stefaniapedrazzi and others added 5 commits November 16, 2020 15:13
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@omichel omichel merged commit 675f6d1 into master Nov 16, 2020
@omichel omichel deleted the documentation-improve-camera-and-display branch November 16, 2020 14:49
omichel added a commit that referenced this pull request Nov 17, 2020
* Create test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Create test_suite_linux_develop.yml

* Update test_suite_linux_develop.yml

* Create test_suite_mac_develop

* Update test_suite_linux_develop.yml

* Rename test_suite_mac_develop to test_suite_mac_develop.yml

* Create test_workflows_synchronization.yml

* Update test_workflows_synchronization.yml

* Update tests_sources.yml

* Update test_suite_windows.yml

* Delete test_workflows_synchronization.yml

* Update citing-webots.md

* Update citing-webots.md

* Update citing-webots.md

* Improve Python guide

* Update docs/guide/using-python.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update discord docs. (#2432)

Co-authored-by: DavidMansolino <DavidMansolino@github.com>

* Fix CI `tests_sources.yml` workflow (#2430)

* Fixed performance issue (#2434)

* Fixed performance issue

* changelog

* Minor performance improvement for Cylinders and Capsules (#2437)

* Improve stability and performance of the IK example (#2439)

* Improve stability and performance of IK

* Update workflow

* Fixed typo (#2440)

* Update jointparameters.md (#2444)

* Update jointparameters.md

* Update jointparameters.md

* Update Discord Docs (#2446)

* Update discord docs.

* Update discord_updater.yml

* Update discord_updater.yml

Co-authored-by: DavidMansolino <DavidMansolino@github.com>
Co-authored-by: Darko Lukić <lukicdarkoo@gmail.com>

* Improve macOS installation instructions (#2449)

* Update installation-procedure.md

* Update installation-procedure.md

* Update installation-procedure.md

* Update installation-procedure.md

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Improved

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Fix Python Display.imageNew and improve documentation (#2443)

* Add documentation of image format in Camera section

* Add examples

* Fix Display examples

* Improve documentation of Python getImageArray function

* update Changelog

* Fix free of invalid pointer

* Add bug fix in ChangeLog

* Improve fix of invalid pointer free

* Update Python example

* Add pixel format in status bar

* Add description of pixel format in status bar

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/camera.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Fix merge

Co-authored-by: David Mansolino <mansolino.david@gmail.com>
Co-authored-by: Darko Lukić <lukicdarkoo@gmail.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: DavidMansolino <DavidMansolino@github.com>
stefaniapedrazzi added a commit that referenced this pull request Nov 18, 2020
* Create test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Create test_suite_linux_develop.yml

* Update test_suite_linux_develop.yml

* Create test_suite_mac_develop

* Update test_suite_linux_develop.yml

* Rename test_suite_mac_develop to test_suite_mac_develop.yml

* Create test_workflows_synchronization.yml

* Update test_workflows_synchronization.yml

* Update tests_sources.yml

* Update test_suite_windows.yml

* Delete test_workflows_synchronization.yml

* Update citing-webots.md

* Update citing-webots.md

* Update citing-webots.md

* Improve Python guide

* Update docs/guide/using-python.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update discord docs. (#2432)

Co-authored-by: DavidMansolino <DavidMansolino@github.com>

* Fix CI `tests_sources.yml` workflow (#2430)

* Fixed performance issue (#2434)

* Fixed performance issue

* changelog

* Minor performance improvement for Cylinders and Capsules (#2437)

* Improve stability and performance of the IK example (#2439)

* Improve stability and performance of IK

* Update workflow

* Fixed typo (#2440)

* Update jointparameters.md (#2444)

* Update jointparameters.md

* Update jointparameters.md

* Update Discord Docs (#2446)

* Update discord docs.

* Update discord_updater.yml

* Update discord_updater.yml

Co-authored-by: DavidMansolino <DavidMansolino@github.com>
Co-authored-by: Darko Lukić <lukicdarkoo@gmail.com>

* Improve macOS installation instructions (#2449)

* Update installation-procedure.md

* Update installation-procedure.md

* Update installation-procedure.md

* Update installation-procedure.md

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Improved

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Fix Python Display.imageNew and improve documentation (#2443)

* Add documentation of image format in Camera section

* Add examples

* Fix Display examples

* Improve documentation of Python getImageArray function

* update Changelog

* Fix free of invalid pointer

* Add bug fix in ChangeLog

* Improve fix of invalid pointer free

* Update Python example

* Add pixel format in status bar

* Add description of pixel format in status bar

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/camera.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Enhancement Linux installation scripts (#2451)

* Fix installation of nodejs on Ubuntu 18.04: npm could not be installed due to conflicts with ros (libssl1.0 vs libssl1.1)

* Adjust other dependencies

* Remove unneeded sudo

* Improved Visual C++ wizard explanations (#2458)

* Fixed a warning displayed by Visual C++ (#2457)

* Update windows installation instructions (#2460)

* Update language-setup.md

* Update installation-procedure.md

* Update menu.md

* Update installation-procedure.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Fix subtitle issue (#2461)

* Update setup-ros GitHub action (#2465)

* Update setup-ros GitHub action

* Update test_suite_linux_develop.yml

Co-authored-by: David Mansolino <mansolino.david@gmail.com>
Co-authored-by: Darko Lukić <lukicdarkoo@gmail.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: DavidMansolino <DavidMansolino@github.com>
Co-authored-by: Simon Steinmann <52213164+Simon-Steinmann@users.noreply.github.com>
stefaniapedrazzi added a commit that referenced this pull request Nov 26, 2020
* Create test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Create test_suite_linux_develop.yml

* Update test_suite_linux_develop.yml

* Create test_suite_mac_develop

* Update test_suite_linux_develop.yml

* Rename test_suite_mac_develop to test_suite_mac_develop.yml

* Create test_workflows_synchronization.yml

* Update test_workflows_synchronization.yml

* Update tests_sources.yml

* Update test_suite_windows.yml

* Delete test_workflows_synchronization.yml

* Update citing-webots.md

* Update citing-webots.md

* Update citing-webots.md

* Improve Python guide

* Update docs/guide/using-python.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update discord docs. (#2432)

Co-authored-by: DavidMansolino <DavidMansolino@github.com>

* Fix CI `tests_sources.yml` workflow (#2430)

* Fixed performance issue (#2434)

* Fixed performance issue

* changelog

* Minor performance improvement for Cylinders and Capsules (#2437)

* Improve stability and performance of the IK example (#2439)

* Improve stability and performance of IK

* Update workflow

* Fixed typo (#2440)

* Update jointparameters.md (#2444)

* Update jointparameters.md

* Update jointparameters.md

* Update Discord Docs (#2446)

* Update discord docs.

* Update discord_updater.yml

* Update discord_updater.yml

Co-authored-by: DavidMansolino <DavidMansolino@github.com>
Co-authored-by: Darko Lukić <lukicdarkoo@gmail.com>

* Improve macOS installation instructions (#2449)

* Update installation-procedure.md

* Update installation-procedure.md

* Update installation-procedure.md

* Update installation-procedure.md

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Improved

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Fix Python Display.imageNew and improve documentation (#2443)

* Add documentation of image format in Camera section

* Add examples

* Fix Display examples

* Improve documentation of Python getImageArray function

* update Changelog

* Fix free of invalid pointer

* Add bug fix in ChangeLog

* Improve fix of invalid pointer free

* Update Python example

* Add pixel format in status bar

* Add description of pixel format in status bar

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/camera.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Enhancement Linux installation scripts (#2451)

* Fix installation of nodejs on Ubuntu 18.04: npm could not be installed due to conflicts with ros (libssl1.0 vs libssl1.1)

* Adjust other dependencies

* Remove unneeded sudo

* Improved Visual C++ wizard explanations (#2458)

* Fixed a warning displayed by Visual C++ (#2457)

* Update windows installation instructions (#2460)

* Update language-setup.md

* Update installation-procedure.md

* Update menu.md

* Update installation-procedure.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Fix subtitle issue (#2461)

* Update setup-ros GitHub action (#2465)

* Update setup-ros GitHub action

* Update test_suite_linux_develop.yml

* Update Discord Docs (#2474)

* Update discord docs.

* Update discord docs.

* Update discord_updater.yml

Co-authored-by: DavidMansolino <DavidMansolino@github.com>
Co-authored-by: Darko Lukić <lukicdarkoo@gmail.com>

* Upload all the Linux packages using GitHub Actions (#2473)

* Upload all the Linux packages using GitHub Actions

* Revert wrong change

* Create tarball and debain package on Ubuntu 16.04

* Try to fix packagin compilation error

* Try to fix packagin compilation error

* Create DEB package on Ubuntu 18.04

* Remove unused ubuntu 16.04 test run

* Upload packages for Ubuntu 18.04

* Remove Ubuntu 16.04 support from documentation

* Update test_suite_linux.yml

* Update test_suite_linux_develop.yml

* Add xvfb to requirements. (#2466)

* Add xvfb to requirements.

* Move xvfb from runtime dep to compilation dep..

* Only install & make w/ xvfb if DISPLAY is not set.

* Update scripts/install/linux_runtime_dependencies.sh

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update scripts/packaging/Makefile

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update scripts/packaging/Makefile

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Use xvfb if DISPLAY (instead of TRAVIS) not set.

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Fix tarball package name for Ubuntu 18.04 (#2475)

Co-authored-by: David Mansolino <mansolino.david@gmail.com>
Co-authored-by: Darko Lukić <lukicdarkoo@gmail.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: DavidMansolino <DavidMansolino@github.com>
Co-authored-by: Simon Steinmann <52213164+Simon-Steinmann@users.noreply.github.com>
Co-authored-by: Dean Brettle <dean@brettle.com>
stefaniapedrazzi added a commit that referenced this pull request Dec 3, 2020
* Create test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Update test_suite_windows.yml

* Create test_suite_linux_develop.yml

* Update test_suite_linux_develop.yml

* Create test_suite_mac_develop

* Update test_suite_linux_develop.yml

* Rename test_suite_mac_develop to test_suite_mac_develop.yml

* Create test_workflows_synchronization.yml

* Update test_workflows_synchronization.yml

* Update tests_sources.yml

* Update test_suite_windows.yml

* Delete test_workflows_synchronization.yml

* Update citing-webots.md

* Update citing-webots.md

* Update citing-webots.md

* Improve Python guide

* Update docs/guide/using-python.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update discord docs. (#2432)

Co-authored-by: DavidMansolino <DavidMansolino@github.com>

* Fix CI `tests_sources.yml` workflow (#2430)

* Fixed performance issue (#2434)

* Fixed performance issue

* changelog

* Minor performance improvement for Cylinders and Capsules (#2437)

* Improve stability and performance of the IK example (#2439)

* Improve stability and performance of IK

* Update workflow

* Fixed typo (#2440)

* Update jointparameters.md (#2444)

* Update jointparameters.md

* Update jointparameters.md

* Update Discord Docs (#2446)

* Update discord docs.

* Update discord_updater.yml

* Update discord_updater.yml

Co-authored-by: DavidMansolino <DavidMansolino@github.com>
Co-authored-by: Darko Lukić <lukicdarkoo@gmail.com>

* Improve macOS installation instructions (#2449)

* Update installation-procedure.md

* Update installation-procedure.md

* Update installation-procedure.md

* Update installation-procedure.md

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Improved

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update docs/guide/installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update installation-procedure.md

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Fix Python Display.imageNew and improve documentation (#2443)

* Add documentation of image format in Camera section

* Add examples

* Fix Display examples

* Improve documentation of Python getImageArray function

* update Changelog

* Fix free of invalid pointer

* Add bug fix in ChangeLog

* Improve fix of invalid pointer free

* Update Python example

* Add pixel format in status bar

* Add description of pixel format in status bar

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/camera.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update docs/reference/display.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Enhancement Linux installation scripts (#2451)

* Fix installation of nodejs on Ubuntu 18.04: npm could not be installed due to conflicts with ros (libssl1.0 vs libssl1.1)

* Adjust other dependencies

* Remove unneeded sudo

* Improved Visual C++ wizard explanations (#2458)

* Fixed a warning displayed by Visual C++ (#2457)

* Update windows installation instructions (#2460)

* Update language-setup.md

* Update installation-procedure.md

* Update menu.md

* Update installation-procedure.md

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Fix subtitle issue (#2461)

* Update setup-ros GitHub action (#2465)

* Update setup-ros GitHub action

* Update test_suite_linux_develop.yml

* Update Discord Docs (#2474)

* Update discord docs.

* Update discord docs.

* Update discord_updater.yml

Co-authored-by: DavidMansolino <DavidMansolino@github.com>
Co-authored-by: Darko Lukić <lukicdarkoo@gmail.com>

* Upload all the Linux packages using GitHub Actions (#2473)

* Upload all the Linux packages using GitHub Actions

* Revert wrong change

* Create tarball and debain package on Ubuntu 16.04

* Try to fix packagin compilation error

* Try to fix packagin compilation error

* Create DEB package on Ubuntu 18.04

* Remove unused ubuntu 16.04 test run

* Upload packages for Ubuntu 18.04

* Remove Ubuntu 16.04 support from documentation

* Update test_suite_linux.yml

* Update test_suite_linux_develop.yml

* Add xvfb to requirements. (#2466)

* Add xvfb to requirements.

* Move xvfb from runtime dep to compilation dep..

* Only install & make w/ xvfb if DISPLAY is not set.

* Update scripts/install/linux_runtime_dependencies.sh

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update scripts/packaging/Makefile

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Update scripts/packaging/Makefile

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Use xvfb if DISPLAY (instead of TRAVIS) not set.

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>

* Fix tarball package name for Ubuntu 18.04 (#2475)

* Publish macOS package from GitHub Action (#2478)

* Publish macOS package from GitHub Action

* Trigger test

* Test

* Test is done

* Reduce weight of the fridge doors (#2486)

* Robotino3.proto is modified to increase movement speed and accuracy and change orientation to FLU. (#2479)

* Robotino3.proto is modified to increase movement accuracy. Added a new controller for exact movement. Wheels moved into another proto to ensure symmetry.

* made Robotino3Wheel.proto hidden, added licence to FastRobotino.cpp and clang-formatted it.

* Fixed clang_format tests

* removed FastRobotino.cpp controller. added code to the original controller robotino3.c, base.c, base.h. changed the ContactProperties in the world file.

* clang format

* *.proto field nr -> number
robotino3.md contactProperties updated

* Robotino3Wheel.proto comment changed

* Update projects/robots/festo/robotino3/protos/Robotino3Wheel.proto

* clean-up

* Update Robotino3Wheel.proto

* Update base.c

* Update base.h

* Update projects/robots/festo/robotino3/controllers/robotino3/base.c

* Update projects/robots/festo/robotino3/controllers/robotino3/robotino3.c

* Update projects/robots/festo/robotino3/controllers/robotino3/robotino3.c

* Update projects/robots/festo/robotino3/controllers/robotino3/robotino3.c

* Update projects/robots/festo/robotino3/controllers/robotino3/robotino3.c

* Update projects/robots/festo/robotino3/controllers/robotino3/robotino3.c

* Update projects/robots/festo/robotino3/controllers/robotino3/robotino3.c

* removed long comment in Robotino3.proto
added hint to use only with coordinateSystem NUE in robotino3.md

* fixed typo in worldinfo.md
timeStep -> time_step back again in base.c

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Windows Develop Nightly Test (#2489)

* Create test_suite_windows_develop.yml

* Update test_suite_windows_develop.yml

* Update tests_sources.yml

* Convert proto files to multi-file protos (#2226)

* Convert proto files to multi-file protos

Extracts the Mesh-geometries and puts them in a sub-folder (with hidden tag). 
--all  let's you select a folder. The script converts every proto in that folder and places the conversion with the same structure in a new folder.

* Remove trailing spaces.

* Cleanup.

* Moved.

* empty line.

* Add execution flag.

* Update proto2multi.py

* pep8 formating.

* Update scripts/proto_splitter/proto2multi.py

Co-authored-by: David Mansolino <mansolino.david@gmail.com>

* Update scripts/proto_splitter/proto2multi.py

Co-authored-by: David Mansolino <mansolino.david@gmail.com>

* changed behavior

Now it creates a backup of the original folder and replaces everything directly. Also added rejection of protos with 'hidden' tags or no header at all

* Update scripts/proto_splitter/proto2multi.py

Co-authored-by: David Mansolino <mansolino.david@gmail.com>

* Update scripts/proto_splitter/proto2multi.py

Co-authored-by: David Mansolino <mansolino.david@gmail.com>

* Update scripts/proto_splitter/proto2multi.py

Co-authored-by: David Mansolino <mansolino.david@gmail.com>

* Update scripts/proto_splitter/proto2multi.py

Co-authored-by: David Mansolino <mansolino.david@gmail.com>

* Update proto2multi.py

* Update scripts/proto_splitter/proto2multi.py

Co-authored-by: David Mansolino <mansolino.david@gmail.com>

* Update scripts/proto_splitter/proto2multi.py

Co-authored-by: David Mansolino <mansolino.david@gmail.com>

* Update proto2multi.py

* repeating header fix

Co-authored-by: David Mansolino <David.Mansolino@cyberbotics.com>
Co-authored-by: David Mansolino <mansolino.david@gmail.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Fix artifacts upload issues (#2485)

* Do not upload debian package for testing

* Delete artifacts at the end of the workflow

* Fix syntax

* Fix indentation

* Add action to remove old artifacts

* Delete artifactis on macOS and Windows workflows

* Fix remove-old-artifacts.yml

* Try a different action

* Remove action to remove old artifacts

* Remove some conditions

* Delete artifacts in case of skipped or failed jobs

* Fix deleting artifacts at the end of the workflow

* Fix artifact name in delete job

* Improve conditions for artifacts upload step on macOS and Windows workflows

* Update header version

* Fix wrong merge change

* Fix wrong merge change

* Fix wrong merge change

Co-authored-by: David Mansolino <mansolino.david@gmail.com>
Co-authored-by: Darko Lukić <lukicdarkoo@gmail.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: DavidMansolino <DavidMansolino@github.com>
Co-authored-by: Simon Steinmann <52213164+Simon-Steinmann@users.noreply.github.com>
Co-authored-by: Dean Brettle <dean@brettle.com>
Co-authored-by: Thomas Feldmeier <73528085+Thomas-Feldmeier@users.noreply.github.com>
Co-authored-by: David Mansolino <David.Mansolino@cyberbotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improve or fix the documentation (MD files only, no software development) test suite Start the test suite
Development

Successfully merging this pull request may close these issues.

None yet

2 participants