-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create e-puck2 driver #59
Conversation
DeepCode's analysis on #2d9c58 found:3 minor issues. ✔️ 0 issues were fixed. 👉 View analysis in DeepCode’s Dashboard |
Co-Authored-By: David Mansolino <David.Mansolino@cyberbotics.com>
@DavidMansolino Should we change a name from |
That's a good idea indeed, but in that case, please make sure that it is working with the simulated e-puck 1 too (the controller should handle the missing devices such as ToF and Gyro). |
Well, gyro supposed to be available in e-puck1 as well according to documentation. It seems it misses in the model. Here is a comparison between e-puck1 and e-puck2: Anyway, it is a good idea to make everything optional to preserve backwards compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note also that to make this code easily re-usable and make it more generic I would like that you create a WebotsDifferentialWheelNode
(or any better name) that inherits from WebotsNode
and is in the webots_ros2_core
package and provides all the functionalities related to the odom publisher and cmd_vel subscriber (the EPuckDriver
class will then inherit from this class).
This way it will be very simple to create new differential wheels robot nodes based on this excellent code you did. For example the webots_ros2_tiago
could use it.
But please don't do this in this PR as it is already very good and functional like this (and start to be quite big 😉).
I love the idea! I will do it! Gazebo is doing something similar (http://gazebosim.org/tutorials?tut=ros_gzplugins) but this could be a cleaner and more configurable approach. |
Co-Authored-By: David Mansolino <David.Mansolino@cyberbotics.com>
Co-Authored-By: David Mansolino <David.Mansolino@cyberbotics.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Description
ROS2 e-puck2 driver for Webots should be created. The API should match to one implemented for
epuck_ros2
(https://github.com/cyberbotics/epuck_ros2).Tasks
epuck_ros2
epuck_ros2
API