Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid consuming too much memory #14

Closed
ymmt2005 opened this issue Jun 1, 2017 · 2 comments
Closed

Avoid consuming too much memory #14

ymmt2005 opened this issue Jun 1, 2017 · 2 comments
Assignees
@nishitaniyuki
Labels
bug enhancement

Comments

@ymmt2005
Copy link
Member

ymmt2005 commented Jun 1, 2017 •
edited
Loading

aptutil/mirror/mirror.go

Line 280 in ec162e2

data, err := ioutil.ReadAll(resp.Body)

go-apt-mirror keeps downloaded data in memory.
This may result in excessive memory usage while downloading debs.

go-apt-cacher has a similar issue.
@ymmt2005 ymmt2005 self-assigned this Jun 1, 2017
@ymmt2005 ymmt2005 changed the title Avoid consuming memory while downloading Avoid consuming too much memory Jun 1, 2017
@ymmt2005
Copy link
Member Author

ymmt2005 commented Jun 1, 2017

aptutil/mirror/mirror.go

Line 272 in ec162e2

log.Debug("downloaded", map[string]interface{}{

This "downloaded" message is also confusing. In fact, file body will be read after the message is logged.

@ymmt2005 ymmt2005 mentioned this issue Oct 4, 2017
Closed
@ymmt2005
Copy link
Member Author

ymmt2005 commented Oct 4, 2017

@henrich This issue will be fixed shortly. We are fixing.
Cc: @nishitaniyuki

@ymmt2005 ymmt2005 assigned nishitaniyuki and unassigned ymmt2005 Oct 4, 2017
@ymmt2005 ymmt2005 added the bug label Oct 4, 2017
@nishitaniyuki nishitaniyuki mentioned this issue Oct 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nishitaniyuki nishitaniyuki

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ymmt2005 @nishitaniyuki