Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimistic lock support #27

Closed
wolfy-j opened this issue Aug 13, 2019 · 6 comments
Closed

Optimistic lock support #27

wolfy-j opened this issue Aug 13, 2019 · 6 comments
Labels
type:feature New feature.
Milestone

Comments

@wolfy-j
Copy link
Contributor

wolfy-j commented Aug 13, 2019

Simple mapper modification to issue different command set for queue update and queue delete with version check.

@mishfish
Copy link
Contributor

mishfish commented Feb 18, 2020

Do you mean add something like @Version annotation for schema description and then check this field in update?

@wolfy-j
Copy link
Contributor Author

wolfy-j commented Feb 19, 2020

Hi, technically it will require the development of custom Mapper which can be enabled via schema generator and annotation. But yes, it will be version column driven. Architecture is ready for that.

@fractalzombie
Copy link

What about optimistic lock at this moment?

@wolfy-j
Copy link
Contributor Author

wolfy-j commented Nov 11, 2020

Feature development is currently on hold (till the end of the year). We are working on a new massive component (https://github.com/temporalio/proposals/blob/master/php/php-rr-sdk.md) which consumes all the team attention. You can implement this feature by youself vis custom command in your mapper.

@rauanmayemir
Copy link
Contributor

Could this be squeezed in for V2?

@roxblnfk
Copy link
Member

roxblnfk commented Nov 19, 2021

Could this be squeezed in for V2?

This is done as entity behavior
https://github.com/cycle/entity-behavior/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature.
Projects
Archived in project
Development

No branches or pull requests

5 participants