Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cycle-scripts-es-browserify): Fix babel transpilation by adding .babelrc #13

Closed
wants to merge 1 commit into from

Conversation

Widdershin
Copy link
Member

No description provided.

@geovanisouza92
Copy link
Member

@Widdershin What is this about?

@Widdershin
Copy link
Member Author

babel only seems to work if I create a .babelrc file, which is what I'm used to. For example, using import will not work unless you add this .babelrc file.

@geovanisouza92
Copy link
Member

Have you see that this option is already included on the build script?

@Widdershin
Copy link
Member Author

I hadn't seen that, I was running into this running npm test.

@geovanisouza92
Copy link
Member

I have tested manually each flavor, with each stream lib to ensure that it works seamlessly until #3 be resolved.

@Widdershin
Copy link
Member Author

It works off the bat, but if you say, use an import in a test file, it will break.

@geovanisouza92
Copy link
Member

Ok, it seems a bug then.

@geovanisouza92 geovanisouza92 mentioned this pull request Oct 18, 2016
nickbalestra pushed a commit to nickbalestra/create-cycle-app that referenced this pull request Oct 18, 2016
@nickbalestra nickbalestra deleted the fix-babel-in-es-browserify branch October 19, 2016 20:34
perjerz pushed a commit to perjerz/create-cycle-app that referenced this pull request Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

2 participants