Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cycle-scripts-es-webpack): Test can now be written in ES6 #15

Merged
merged 1 commit into from
Oct 18, 2016

Conversation

nickbalestra
Copy link
Collaborator

  • I ran npm test for the package I'm modifying
  • I used npm run commit instead of git commit

ISSUES CLOSED: #14
REPLACES #13

Rationale: Instead of adding a babel config file in the template, having it copied over when create-cycle-app create an app, we just configure it temporary via package.json . Once we take-off-training-wheels we remove the config from the package.json and we copy on the root as .bablrc file. In this way we can hide complexity away from the user, until the very moment he decide to do so.

IMHO, create-cycle-app should always try to hide complexity and just don't make the user think. Especially for core flavors. So any configuration and setting should be handled by create-cycle-app as much as possible leaving the user with a super clean project structure to work on and focus on.

@geovanisouza92 @Widdershin what you think? If you are ok with it, feel free to close #13 in favor of this

@Widdershin
Copy link
Member

This looks good to me 😄

Feel free to close #13 and do it this way instead.

@geovanisouza92
Copy link
Member

Really good job @nickbalestra! Thank you.

And thanks to @Widdershin for pointing the issue!

@geovanisouza92 geovanisouza92 merged commit 2a45a9e into cyclejs-community:master Oct 18, 2016
perjerz pushed a commit to perjerz/create-cycle-app that referenced this pull request Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using ES6 on tests
3 participants