Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethinking scripts post take-off-training-wheels #4

Closed
nickbalestra opened this issue Oct 15, 2016 · 5 comments
Closed

Rethinking scripts post take-off-training-wheels #4

nickbalestra opened this issue Oct 15, 2016 · 5 comments

Comments

@nickbalestra
Copy link
Collaborator

While working ont he es6-webpack flavour I noticed that would be nice to be able to have a cleaner post take-off-training-wheels.js version of the scripts.

At the moment we simply move them in the .scripts folder and we reference them wihin the package.json scripts field.

Some of them could be simply rewritten as cli cmds within the npm script, together with some files being created whenever needed (i.e: .babelrc and webpack.config.js).

Once we have all the 4 basics flavours in place we can perhaps start thinking on how to improve this part of the experience.

@geovanisouza92
Copy link
Member

Yeah, this is something that I thought while working at the first flavor. As I took create-react-app as reference, and it only have a single bloated react-scripts, this is something that I leave to be addressed later.

Each flavor is completely independent, and could evolve freely, so, while maintaining the same contract with other flavors, each script could do what is more suitable for each case.

So, writing configuration files and using npm scripts more extensively, which is something the user that uses take-off-training-wheels probably will do, is not only OK, but desirable in some cases. The idea is that take-off-training-wheels give all the power (and responsibility) to the user.

@nickbalestra
Copy link
Collaborator Author

nickbalestra commented Oct 15, 2016

Totally agree.
On a side note, I see we don't have any labels for issues, perhaps we want to add just a couple of labels for basic things, like nice to have, bug, discussion, ... ?
EDIT: Ok, I see now that we have labels but it seems that only collaborators cat tag issues with them

@geovanisouza92
Copy link
Member

Yeah, I just added the default labels, but I'm thinking if makes sense to create more, like @staltz did on cyclejs monorepo... That is a bigger project, with lot contributions caming from everywere, so, I think that was a must.

@nickbalestra
Copy link
Collaborator Author

Nice job with labels, me likes it 💯 !
#19 and #15 address this issue in regards to how we handle .babelrc config files.

TODO: make sure webpack based flavors also properly generates:

  • webpack.config.js
  • webpack.production.config.js

@jvanbruegge
Copy link
Collaborator

I did this here: https://github.com/cyclejs-community/create-cycle-app-flavors/blob/master/packages/cycle-scripts-one-fits-all/scripts/eject.js
eject does not leave any traces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants