Duplicate photo uploads

[smsm1]

I'm finding that when I upload a photo, it'll often be uploaded twice, rather than just once. I think it may be more likely to happen when I'm using mobile data, and the phone thinks there is an error on the upload, so tries again.

[smsm1]

I have seen an occasion where the same photo has been uploaded 3 times without me trying.

http://www.cyclestreets.net/location/32185/
http://www.cyclestreets.net/location/32186/
http://www.cyclestreets.net/location/32187/

[jezhiggins]

I think the problem arises when the phone goes to sleep during the upload. The app gets left in an inconsistent state, and so when phone is woken up again it starts the upload again.

My plan is to move the upload into the background, reporting through the nofications area (in the same way as when your downloading something from the Android Market, say). That should allow to sidestep potential inconsistency completely.

[si-the-pie]

I've had the same problem as smsm1 has reported, while uploading photos while out on a ride with cyclesheffied at the CTC CycleNation conference this w/e. I take the photo then work thru the screens and when I've pressed upload I put it in my pocket and try and catch up with the group. Its great being able to upload photos while on a ride like this.

While I'm here, there are a couple of other points:

1. I usually have GPS turned on and wait until the photo is geolocated before I take it. But the photo upload screen does not seem to register that. It asks me to set a location. I'd expect it to show the currently detected location, or possibly enable me to 'use current location'.
2. I'd like my uploads to be 'auto-tweeted' to my twitter account. Because when I'm at a conference like this people want to know what's going on! I thnk the first 140 chars of the caption should be the tweet.
3. The app did crash a few times while I was using it, mostly on the upload phase, I think.

[si-the-pie]

Sorry I didn't know what I was doing just now!

[si-the-pie]

Still getting this issue, e.g.:

http://cambridge.cyclestreets.net/location/35277/
and
http://cambridge.cyclestreets.net/location/35278/

They seem to have been uploaded within 26 seconds of each other.

[si-the-pie]

Just downloaded Jan 13 edition of the app. The photo adding does not seem to work at all properly now. There is no prompt to set the location or subject of what is being photoed.

[jezhiggins]

I'm in the middle of working on that part of app at the moment, so I might break and come back. Keep an eye builds over the next few days.

----- Reply message -----
From: "si-the-pie" reply@reply.github.com
Date: Sat, Jan 14, 2012 17:40
Subject: [android] Duplicate photo uploads (#32)
To: "Jez Higgins" jez@jezuk.co.uk

Just downloaded Jan 13 edition of the app. The photo adding does not seem to work at all properly now. There is no prompt to set the location or subject of what is being photoed.

---

Reply to this email directly or view it on GitHub:
#32 (comment)

[jezhiggins]

Rejigged the state transitions in Add Photo (again!) to try and avoid this.

[si-the-pie]

I've just installed the 18 Jan edition.

Going into Add Photo causes the application to Close, giving me the force close dialog.

HTC Wildfire.

[jezhiggins]

Balls. I can't reproduce it either. sigh Will see what I can do over the weekend.

[jezhiggins]

Hi chaps, could you install today's build and let me know how get in with it? Thanks.

[si-the-pie]

After downloading today's updated app, I added a photo, then it gave the Force Close. But the photo had made it on to CycleStreets.

I have since completely removed the application again and re-installed. Now I have uploaded several photos without it crashing.

Also I have yet to see any duplication - so this is looking good.

[si-the-pie]

Now that the uploading is more reliable I have started making more use of the app - uploading almost on a daily basis over the last week. It all feels a lot more solid now and that is very pleasing.

One minor niggle is that sometimes when it goes to the locate screen it shows my position rather than the geo-located position. I say sometimes because it doesn't always seem to do that, I'll continue to observe this behaviour and report back when I have a clearer view of the circumstances in which it is happening.

[jezhiggins]

In those cases, has it placed the red X then recentred on your location? If so, there's some kind of timing issue. If not, and the red X isn't placed, it might be because the photo doesn't have any geolocation data after all. As you know, it takes a little while to get a GSM lock, so if you whip out your phone and snap a picture it doesn't always have a lock, so it won't add geolocation data to the photo.

[si-the-pie]

On 1 February 2012 21:15, Jez Higgins
reply@reply.github.com
wrote:

In those cases, has it placed the red X then recentred on your location?

Yes, I believe it has done that.

 If so, there's some kind of timing issue.  If not, and the red X isn't placed, it might be because the photo doesn't have any geolocation data after all.  As you know, it takes a little while to get a GSM lock, so if you whip out your phone and snap a picture it doesn't always have a lock, so it won't add geolocation data to the photo.

I have usually been patient enough to wait for the GSM lock, and in
fact all the photos I've uploaded with the GSM lock were set in the
right place. So it might be the timing issue as you say. There's no
obvious way of bringing the X into view.

To me this definitely fits into the category of minor niggles that are
not really problems, but which can be quite fiddly to get right!

---

Reply to this email directly or view it on GitHub:
#32 (comment)

Simon

Simon Nuttall
100 Thoday Street
Cambridge
CB1 3AX
01223 500902
+44 1223 500902